From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el Date: Fri, 14 Aug 2020 09:05:00 +0300 Message-ID: <83tux5lq43.fsf@gnu.org> References: <20200812175454.4839.92908@vcs0.savannah.gnu.org> <20200812175456.C5D122172E@vcs0.savannah.gnu.org> <874kp7lpda.fsf@gnus.org> <87mu2zhssl.fsf@gnus.org> <83imdmn0vr.fsf@gnu.org> <835z9mmy4t.fsf@gnu.org> <83364qmr7f.fsf@gnu.org> <83zh6yl7wr.fsf@gnu.org> <83y2mil619.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 14 08:06:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Sr1-0002xU-WE for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Aug 2020 08:06:16 +0200 Original-Received: from localhost ([::1]:49456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Sr1-0007Ls-2P for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Aug 2020 02:06:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6Spu-0006nC-DG for emacs-devel@gnu.org; Fri, 14 Aug 2020 02:05:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40475) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Spt-0005rn-TT; Fri, 14 Aug 2020 02:05:05 -0400 Original-Received: from [176.228.60.248] (port=3783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6Sps-0004EB-FU; Fri, 14 Aug 2020 02:05:05 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 13 Aug 2020 15:54:43 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253755 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Thu, 13 Aug 2020 15:54:43 -0400 > > >> >> > In unibyte buffers the coding-system doesn't matter. > >> > Again, this factoid isn't relevant to the issue at hand. > >> Not sure what is the issue at hand at this point > > The code in eudc-bob.el, of course. > > In that particular case, I don't know whether the coding-system will > make a difference because I don't know if the `data` will contain > newlines and if so whether their encoding is significant. If newline conversion is the only consideration, we could bind inhibit-eol-conversion instead, no need for the coding-system stuff. My point is that code which makes a buffer unibyte and then sets its buffer-file-coding-system yells "FIXME!", so it is best not to write it.