From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: shr using `make-xwidget' incorrectly
Date: Thu, 11 Nov 2021 10:01:58 +0200 [thread overview]
Message-ID: <83tugj15op.fsf@gnu.org> (raw)
In-Reply-To: <87fss3xjdc.fsf@yahoo.com> (message from Po Lu on Thu, 11 Nov 2021 15:05:19 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: larsi@gnus.org, emacs-devel@gnu.org
> Date: Thu, 11 Nov 2021 15:05:19 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> I think the best thing to do in this case would be to introduce a
> >> `dead' state for xwidgets, not unlike killed buffers and dead frames,
> >> which an xwidget is set to after being killed.
> >>
> >> Then, performing any sort of operation on a killed xwidget can either
> >> throw an error, or do nothing.
>
> > Why can't we release the GTK resources when such a buffer is killed?
>
> We are releasing the GTK resources when such a buffer is killed. This
> is the problem here: code that uses `CHECK_XWIDGET' won't catch the case
> where the GTK resources are released, but there are still references to
> the xwidget, which causes use-after-frees when trying to redisplay the
> xwidget, or when calling, say, `xwidget-webkit-goto-uri' on the xwidget.
Isn't there some indication in the xwidget that its GTK resources were
freed? If not, can we add such an indication and set it when we free
those resources?
next prev parent reply other threads:[~2021-11-11 8:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87sfw31mok.fsf.ref@yahoo.com>
2021-11-11 1:54 ` shr using `make-xwidget' incorrectly Po Lu
2021-11-11 3:26 ` Lars Ingebrigtsen
2021-11-11 3:38 ` Po Lu
2021-11-11 3:41 ` Lars Ingebrigtsen
2021-11-11 3:43 ` Lars Ingebrigtsen
2021-11-11 4:46 ` Po Lu
2021-11-11 4:56 ` Lars Ingebrigtsen
2021-11-11 5:10 ` Po Lu
2021-11-11 12:33 ` Lars Ingebrigtsen
2021-11-11 12:37 ` Po Lu
2021-11-11 12:43 ` Lars Ingebrigtsen
2021-11-11 12:47 ` Po Lu
2021-11-11 6:37 ` Introduce "killed" state for xwidgets (Re: shr using `make-xwidget' incorrectly) Po Lu
2021-11-11 7:59 ` Eli Zaretskii
2021-11-11 9:28 ` Po Lu
2021-11-11 12:23 ` Lars Ingebrigtsen
2021-11-11 12:25 ` Po Lu
2021-11-11 15:10 ` Eli Zaretskii
2021-11-12 0:18 ` Po Lu
2021-11-11 6:58 ` shr using `make-xwidget' incorrectly Eli Zaretskii
2021-11-11 7:05 ` Po Lu
2021-11-11 8:01 ` Eli Zaretskii [this message]
2021-11-11 9:27 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tugj15op.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).