unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
       [not found] <E1P1eYK-0004bE-CK@internal.in.savannah.gnu.org>
@ 2010-10-02  1:13 ` Juanma Barranquero
  2010-10-02  7:47   ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2010-10-02  1:13 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Emacs developers

On Fri, Oct 1, 2010 at 13:45, Eli Zaretskii <eliz@gnu.org> wrote:
> ------------------------------------------------------------
> revno: 101703
> committer: Eli Zaretskii <eliz@gnu.org>
> branch nick: trunk
> timestamp: Fri 2010-10-01 13:45:16 +0200
> message:
>  Support TAGS targets in the w32 build.

C:\emacs> cd nt
C:\emacs\nt> make tags

../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
make  -C ../src TAGS TAGS-LISP
make[1]: Entering directory `C:/emacs/src'
make[1]: Circular TAGS <- TAGS dependency dropped.
make -w nt-TAGS-gmake
make[2]: Entering directory `C:/emacs/src'
make -w -C ../nt TAGS
make[3]: Entering directory `C:/emacs/nt'
../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
make -w -C ../src TAGS TAGS-LISP
make[4]: Entering directory `C:/emacs/src'
make[4]: Circular TAGS <- TAGS dependency dropped.
make -w nt-TAGS-gmake
make[5]: Entering directory `C:/emacs/src'
make -w -C ../nt TAGS
make[6]: Entering directory `C:/emacs/nt'
../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
make -w -C ../src TAGS TAGS-LISP

[...etc...]



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
  2010-10-02  1:13 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build Juanma Barranquero
@ 2010-10-02  7:47   ` Eli Zaretskii
  2010-10-02 11:47     ` Juanma Barranquero
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2010-10-02  7:47 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: emacs-devel

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 2 Oct 2010 03:13:29 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> On Fri, Oct 1, 2010 at 13:45, Eli Zaretskii <eliz@gnu.org> wrote:
> > ------------------------------------------------------------
> > revno: 101703
> > committer: Eli Zaretskii <eliz@gnu.org>
> > branch nick: trunk
> > timestamp: Fri 2010-10-01 13:45:16 +0200
> > message:
> >  Support TAGS targets in the w32 build.
> 
> C:\emacs> cd nt
> C:\emacs\nt> make tags
> 
> ../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
> make  -C ../src TAGS TAGS-LISP
> make[1]: Entering directory `C:/emacs/src'
> make[1]: Circular TAGS <- TAGS dependency dropped.
> make -w nt-TAGS-gmake
> make[2]: Entering directory `C:/emacs/src'
> make -w -C ../nt TAGS
> make[3]: Entering directory `C:/emacs/nt'
> ../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
> make -w -C ../src TAGS TAGS-LISP
> make[4]: Entering directory `C:/emacs/src'
> make[4]: Circular TAGS <- TAGS dependency dropped.
> make -w nt-TAGS-gmake
> make[5]: Entering directory `C:/emacs/src'
> make -w -C ../nt TAGS
> make[6]: Entering directory `C:/emacs/nt'
> ../lib-src/oo-spd/i386/etags C:/emacs/nt/*.c
> make -w -C ../src TAGS TAGS-LISP

That's strange.  What version of Make do you use?  Was it compiled to
be case-insensitive or something?  Otherwise, how do you explain this:

> make[1]: Entering directory `C:/emacs/src'
> make[1]: Circular TAGS <- TAGS dependency dropped.

Anyway, I cannot reproduce this with Make 3.82 built out of the box
from the official GNU distro.  Did you invoke Make when any of the
TAGS files involved already existed?  If so, which ones?  I tried with
all the files missing and with all the files existing, but not with
other permutations, so maybe there's something I don't see.

Does the problem go away if you remove these two lines:

  tags: TAGS TAGS-LISP ../nt/TAGS
  .PHONY: tags

from src/makefile.w32-in, or replace `tags' (lower-case) with
`full-tags' or some such?




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
  2010-10-02  7:47   ` Eli Zaretskii
@ 2010-10-02 11:47     ` Juanma Barranquero
  2010-10-02 11:57       ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2010-10-02 11:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

On Sat, Oct 2, 2010 at 09:47, Eli Zaretskii <eliz@gnu.org> wrote:

> That's strange.  What version of Make do you use?

An old one from UnxUtils.

  C:\> make --version
  GNU Make 3.81
  Copyright (C) 2006  Free Software Foundation, Inc.
  This is free software; see the source for copying conditions.
  There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
  PARTICULAR PURPOSE.

  This program built for i386-pc-mingw32

> Was it compiled to be case-insensitive or something?

Don't know, but I wouldn't be surprised.

> Did you invoke Make when any of the
> TAGS files involved already existed?

No.

> Does the problem go away if you remove these two lines:
>
>  tags: TAGS TAGS-LISP ../nt/TAGS
>  .PHONY: tags

Removing these lines and "tags: TAGS" in lib-src/makefile, it finishes
and generates the following files:

  lib-src\TAGS
  nt\TAGS
  src\TAGS
  src\TAGS-LISP

    Juanma



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
  2010-10-02 11:47     ` Juanma Barranquero
@ 2010-10-02 11:57       ` Eli Zaretskii
  2010-10-02 12:15         ` Juanma Barranquero
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2010-10-02 11:57 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: emacs-devel

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 2 Oct 2010 13:47:17 +0200
> Cc: emacs-devel@gnu.org
> 
> >  tags: TAGS TAGS-LISP ../nt/TAGS
> >  .PHONY: tags
> 
> Removing these lines and "tags: TAGS" in lib-src/makefile, it finishes
> and generates the following files:
> 
>   lib-src\TAGS
>   nt\TAGS
>   src\TAGS
>   src\TAGS-LISP

Okay, so let's go for it.  Let's remove the "tags: TAGS" in
lib-src/makefile.w32-in, and let's rename `tags' in
src/makefile.w32-in into `full-tags'.

But since I cannot test this myself, would you please make such a
change and commit it if it works for you?  TIA




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
  2010-10-02 11:57       ` Eli Zaretskii
@ 2010-10-02 12:15         ` Juanma Barranquero
  2010-10-02 13:21           ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2010-10-02 12:15 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

On Sat, Oct 2, 2010 at 13:57, Eli Zaretskii <eliz@gnu.org> wrote:

> But since I cannot test this myself, would you please make such a
> change and commit it if it works for you?  TIA

Committed.

    Juanma



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build.
  2010-10-02 12:15         ` Juanma Barranquero
@ 2010-10-02 13:21           ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2010-10-02 13:21 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: emacs-devel

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 2 Oct 2010 14:15:01 +0200
> Cc: emacs-devel@gnu.org
> 
> On Sat, Oct 2, 2010 at 13:57, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > But since I cannot test this myself, would you please make such a
> > change and commit it if it works for you?  TIA
> 
> Committed.

Thanks, it works for me.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-10-02 13:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E1P1eYK-0004bE-CK@internal.in.savannah.gnu.org>
2010-10-02  1:13 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101703: Support TAGS targets in the w32 build Juanma Barranquero
2010-10-02  7:47   ` Eli Zaretskii
2010-10-02 11:47     ` Juanma Barranquero
2010-10-02 11:57       ` Eli Zaretskii
2010-10-02 12:15         ` Juanma Barranquero
2010-10-02 13:21           ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).