From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Pegoraro <spegoraro@tutive.com>
Cc: emacs-devel@gnu.org
Subject: Re: HiDPI support for wave style underlines
Date: Fri, 18 Aug 2017 11:17:42 +0300 [thread overview]
Message-ID: <83shgpe1cp.fsf@gnu.org> (raw)
In-Reply-To: <CAPzg8ER=5jU6jwhy2uRX-8eGFjnCE3jm8TUkCbPEL9qZcsCeKg@mail.gmail.com> (message from Stephen Pegoraro on Sat, 29 Jul 2017 17:12:20 +0800)
> From: Stephen Pegoraro <spegoraro@tutive.com>
> Date: Sat, 29 Jul 2017 17:12:20 +0800
>
> The patch isn't _only_ for hidpi displays but I can see how my
> original wording comes across that way. It provides correct scaled
> underlining for all displays, hidpi or otherwise. I meant to say that
> I have only implemented this for the Xlib side of things, no W32 or
> mac.
>
> Good point regarding the emacs_abort(), I honestly didn't think through that.
> I have modified x_get_scale_factor to return a new struct
> x_display_scale with x and y components which are used in the wave
> length and height calculation.
> Indentations and comment grammar have been fixed up as well.
Sorry for the long delay.
Thanks, I pushed this with minor changes. Specifically, the function
you added is only used in the same file where it is defined, so it
should be static and its prototype doesn't need to be in xterm.h.
Also, for returning just 2 values, it is better to provide 2 pointer
arguments than to invent a new struct.
next prev parent reply other threads:[~2017-08-18 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 3:29 HiDPI support for wave style underlines Stephen Pegoraro
2017-07-29 7:13 ` Eli Zaretskii
[not found] ` <CAPzg8ETxJYr8Gw0Pag5zpWqA7aap_kduwuGvJaxAT5yvPhNd6w@mail.gmail.com>
2017-07-29 9:12 ` Stephen Pegoraro
2017-08-18 8:17 ` Eli Zaretskii [this message]
2017-08-21 12:20 ` Yuri D'Elia
2017-08-21 12:32 ` Yuri D'Elia
2017-08-21 14:49 ` Eli Zaretskii
2017-08-27 4:26 ` Stephen Pegoraro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shgpe1cp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=spegoraro@tutive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).