From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: HiDPI support for wave style underlines Date: Fri, 18 Aug 2017 11:17:42 +0300 Message-ID: <83shgpe1cp.fsf@gnu.org> References: <83wp6r3ed8.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503044328 14871 195.159.176.226 (18 Aug 2017 08:18:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Aug 2017 08:18:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Pegoraro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 18 10:18:43 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dicUM-0003TY-Qo for ged-emacs-devel@m.gmane.org; Fri, 18 Aug 2017 10:18:42 +0200 Original-Received: from localhost ([::1]:35450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dicUT-0006P9-8o for ged-emacs-devel@m.gmane.org; Fri, 18 Aug 2017 04:18:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dicTg-0006NH-AU for emacs-devel@gnu.org; Fri, 18 Aug 2017 04:18:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dicTa-0000qF-RL for emacs-devel@gnu.org; Fri, 18 Aug 2017 04:17:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dicTa-0000qB-Ng; Fri, 18 Aug 2017 04:17:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4320 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dicTZ-0006N3-F6; Fri, 18 Aug 2017 04:17:54 -0400 In-reply-to: (message from Stephen Pegoraro on Sat, 29 Jul 2017 17:12:20 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217606 Archived-At: > From: Stephen Pegoraro > Date: Sat, 29 Jul 2017 17:12:20 +0800 > > The patch isn't _only_ for hidpi displays but I can see how my > original wording comes across that way. It provides correct scaled > underlining for all displays, hidpi or otherwise. I meant to say that > I have only implemented this for the Xlib side of things, no W32 or > mac. > > Good point regarding the emacs_abort(), I honestly didn't think through that. > I have modified x_get_scale_factor to return a new struct > x_display_scale with x and y components which are used in the wave > length and height calculation. > Indentations and comment grammar have been fixed up as well. Sorry for the long delay. Thanks, I pushed this with minor changes. Specifically, the function you added is only used in the same file where it is defined, so it should be static and its prototype doesn't need to be in xterm.h. Also, for returning just 2 values, it is better to provide 2 pointer arguments than to invent a new struct.