* Remove trailing whitespace from bookmark.el coding cookie
@ 2018-11-19 15:13 Robert Pluim
2018-11-19 17:26 ` Karl Fogel
2018-11-19 17:48 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Robert Pluim @ 2018-11-19 15:13 UTC (permalink / raw)
To: emacs-devel
Thereʼs a trailing space in the coding cookie that bookmark.el writes
to bookmark files, which is allowed but not required by the format,
but makes my git commit hooks complain. Any objections to me
installing the following on master?
modified lisp/bookmark.el
@@ -734,7 +734,7 @@ bookmark-insert-file-format-version-stamp
(if (memq (coding-system-base coding) '(undecided prefer-utf-8))
(setq coding 'utf-8-emacs))
(insert
- (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*- \n"
+ (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*-\n"
bookmark-file-format-version (coding-system-base coding)))
(insert ";;; This format is meant to be slightly human-readable;\n"
";;; nevertheless, you probably don't want to edit it.\n"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Remove trailing whitespace from bookmark.el coding cookie
2018-11-19 15:13 Remove trailing whitespace from bookmark.el coding cookie Robert Pluim
@ 2018-11-19 17:26 ` Karl Fogel
2018-11-19 17:48 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Karl Fogel @ 2018-11-19 17:26 UTC (permalink / raw)
To: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
>Thereʼs a trailing space in the coding cookie that bookmark.el writes
>to bookmark files, which is allowed but not required by the format,
>but makes my git commit hooks complain. Any objections to me
>installing the following on master?
Sounds good to me. The extra space is clearly accidental -- other similar lines in the Emacs source code don't have a space there.
Best regards,
-Karl
>modified lisp/bookmark.el
>@@ -734,7 +734,7 @@ bookmark-insert-file-format-version-stamp
> (if (memq (coding-system-base coding) '(undecided prefer-utf-8))
> (setq coding 'utf-8-emacs))
> (insert
>- (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*- \n"
>+ (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*-\n"
> bookmark-file-format-version (coding-system-base coding)))
> (insert ";;; This format is meant to be slightly human-readable;\n"
> ";;; nevertheless, you probably don't want to edit it.\n"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Remove trailing whitespace from bookmark.el coding cookie
2018-11-19 15:13 Remove trailing whitespace from bookmark.el coding cookie Robert Pluim
2018-11-19 17:26 ` Karl Fogel
@ 2018-11-19 17:48 ` Eli Zaretskii
2018-11-20 10:06 ` Robert Pluim
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-11-19 17:48 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 19 Nov 2018 16:13:41 +0100
>
>
> Thereʼs a trailing space in the coding cookie that bookmark.el writes
> to bookmark files, which is allowed but not required by the format,
> but makes my git commit hooks complain. Any objections to me
> installing the following on master?
No objections from me, and thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Remove trailing whitespace from bookmark.el coding cookie
2018-11-19 17:48 ` Eli Zaretskii
@ 2018-11-20 10:06 ` Robert Pluim
0 siblings, 0 replies; 4+ messages in thread
From: Robert Pluim @ 2018-11-20 10:06 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 19 Nov 2018 16:13:41 +0100
>>
>>
>> Thereʼs a trailing space in the coding cookie that bookmark.el writes
>> to bookmark files, which is allowed but not required by the format,
>> but makes my git commit hooks complain. Any objections to me
>> installing the following on master?
>
> No objections from me, and thanks.
Pushed as 5007c23a6d
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-20 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 15:13 Remove trailing whitespace from bookmark.el coding cookie Robert Pluim
2018-11-19 17:26 ` Karl Fogel
2018-11-19 17:48 ` Eli Zaretskii
2018-11-20 10:06 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).