From: Eli Zaretskii <eliz@gnu.org>
To: "gliao.tw@pm.me" <gliao.tw@pm.me>
Cc: emacs-devel@gnu.org
Subject: Re: face-attribute and face-remapping-alist
Date: Wed, 31 Mar 2021 09:58:48 +0300 [thread overview]
Message-ID: <83sg4bizbr.fsf@gnu.org> (raw)
In-Reply-To: <UPV6ZuVvnhNZ5ptm8_BYi_9ElrzJyGuu6W_Evgm05CShNeLiK0mhjipkOcUSLI_Yne26QtAbZxBrb9GDqT6wkgRjeCuVU88BjmxM4BSwmGk=@pm.me> (gliao.tw@pm.me)
> Date: Wed, 31 Mar 2021 03:05:42 +0000
> From: "gliao.tw@pm.me" <gliao.tw@pm.me>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>
> >From the above example, we can see that `face-attribute' will return results
> *incosistent* with what we see in a buffer which has been updated with
> a theme in buffer-local manner via functions implemented in `face-remap.el'.
Sure, but the only change needed in all the cases you described in
order to return attributes that are aware of the remapping is to look
up the face in face-remapping-alist, before calling face-attribute.
This solution is so easy that I don't understand the need for changing
the behavior of face-attribute in such fundamental and incompatible
ways to produce the same effect.
Am I missing something?
next prev parent reply other threads:[~2021-03-31 6:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 18:53 face-attribute and face-remapping-alist gliao.tw
2021-03-30 19:05 ` Eli Zaretskii
2021-03-30 19:13 ` Eli Zaretskii
2021-03-31 3:05 ` gliao.tw
2021-03-31 3:34 ` gliao.tw
2021-03-31 6:58 ` Eli Zaretskii [this message]
2021-03-31 13:00 ` Clément Pit-Claudel
2021-03-31 13:27 ` Eli Zaretskii
2021-03-31 22:41 ` gliao.tw
2021-04-01 7:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sg4bizbr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gliao.tw@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).