From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: face-attribute and face-remapping-alist Date: Wed, 31 Mar 2021 09:58:48 +0300 Message-ID: <83sg4bizbr.fsf@gnu.org> References: <834kgsjwdf.fsf@gnu.org> <8335wcjvzh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "gliao.tw@pm.me" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 31 08:59:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRUpM-0001t7-BP for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Mar 2021 08:59:44 +0200 Original-Received: from localhost ([::1]:47814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRUpL-0004qk-AS for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Mar 2021 02:59:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRUoN-0004N9-6e for emacs-devel@gnu.org; Wed, 31 Mar 2021 02:58:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55163) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRUoM-0003te-BX; Wed, 31 Mar 2021 02:58:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2386 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lRUoF-0007uw-22; Wed, 31 Mar 2021 02:58:36 -0400 In-Reply-To: (gliao.tw@pm.me) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267210 Archived-At: > Date: Wed, 31 Mar 2021 03:05:42 +0000 > From: "gliao.tw@pm.me" > Cc: "emacs-devel@gnu.org" > > >From the above example, we can see that `face-attribute' will return results > *incosistent* with what we see in a buffer which has been updated with > a theme in buffer-local manner via functions implemented in `face-remap.el'. Sure, but the only change needed in all the cases you described in order to return attributes that are aware of the remapping is to look up the face in face-remapping-alist, before calling face-attribute. This solution is so easy that I don't understand the need for changing the behavior of face-attribute in such fundamental and incompatible ways to produce the same effect. Am I missing something?