Problem with file-local variables in uni-special-lowercase.el

Problem with file-local variables in uni-special-lowercase.el

[Eli Zaretskii]

There's some strange problem with this file: when building Emacs after
it is updated, byte-compilation of various Lisp files fails with error
message like this:

  File local-variables error: (error Recursive load /home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el /home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el /home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el /home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el /home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el)

  In toplevel form:
  international/mule.el:1833:8: Error: Recursive load: "/home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el", "/home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el", "/home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el", "/home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el", "/home/eliz/git/emacs/branch/lisp/international/uni-special-lowercase.el", "/home/eliz/git/emacs/branch/lisp/international/uni-special-uppercase.el"
  Makefile:290: recipe for target '../lisp/international/mule.elc' failed

I guess we try to lower-case some parts of the file-local variables
section, and that causes recursive load or something?

I couldn't get around this except by removing the file-local vars from
the file.

Re: Problem with file-local variables in uni-special-lowercase.el

[Eli Zaretskii]

> Date: Sat, 01 Jan 2022 11:00:08 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> There's some strange problem with this file: when building Emacs after
> it is updated, byte-compilation of various Lisp files fails with error
> message like this:

FWIW, it seems to start happening as soon as charprop.el is
regenerated, whenever the new charprop.el is reloaded by the
byte-compilation process.

Re: Problem with file-local variables in uni-special-lowercase.el

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> There's some strange problem with this file: when building Emacs after
> it is updated, byte-compilation of various Lisp files fails with error
> message like this:

+1, it would be nice if someone fixed this.  I don't know what's going
on, unfortunately.

Re: Problem with file-local variables in uni-special-lowercase.el

[Philipp Stephani]

Am Sa., 1. Jan. 2022 um 14:09 Uhr schrieb Po Lu <luangruo@yahoo.com>:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > There's some strange problem with this file: when building Emacs after
> > it is updated, byte-compilation of various Lisp files fails with error
> > message like this:
>
> +1, it would be nice if someone fixed this.  I don't know what's going
> on, unfortunately.
>

This appears to happen frequently for me as well. Running 'make
gen-clean' in admin/unidata typically fixes it temporarily.

Re: Problem with file-local variables in uni-special-lowercase.el

[Stefan Monnier]

>> There's some strange problem with this file: when building Emacs after
>> it is updated, byte-compilation of various Lisp files fails with error
>> message like this:
>
> FWIW, it seems to start happening as soon as charprop.el is
> regenerated, whenever the new charprop.el is reloaded by the
> byte-compilation process.

Can you provide a recipe to reproduce the problem?


        Stefan

Re: Problem with file-local variables in uni-special-lowercase.el

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 01 Jan 2022 12:57:19 -0500
> 
> >> There's some strange problem with this file: when building Emacs after
> >> it is updated, byte-compilation of various Lisp files fails with error
> >> message like this:
> >
> > FWIW, it seems to start happening as soon as charprop.el is
> > regenerated, whenever the new charprop.el is reloaded by the
> > byte-compilation process.
> 
> Can you provide a recipe to reproduce the problem?

"touch" every file in the working tree, then say "make".

It might also work to delete all the lisp/international/uni-*.el files
and lisp/international/charprop.el, then say "make".

Re: Problem with file-local variables in uni-special-lowercase.el

[Eli Zaretskii]

> Date: Sat, 01 Jan 2022 20:15:07 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> "touch" every file in the working tree

I meant every one of the versioned files.

Re: Problem with file-local variables in uni-special-lowercase.el

[Stefan Monnier]

>> >> There's some strange problem with this file: when building Emacs after
>> >> it is updated, byte-compilation of various Lisp files fails with error
>> >> message like this:
>> >
>> > FWIW, it seems to start happening as soon as charprop.el is
>> > regenerated, whenever the new charprop.el is reloaded by the
>> > byte-compilation process.

[ Apparently `uni-special-lowercase.el` and its friends are preloaded
  in the dump (even though they don't appear in `loadup.el`).  ]

I suspect this problem is newly introduced by the symbol-shorthands
code, which apparently uses just enough more of the `hack-local-variables`
machinery to trigger it.

The patch below seems to circumvent the problem.


        Stefan


diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index de1331e12a9..8b61a88f136 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -2958,8 +2958,14 @@ define-char-code-property
     (or (stringp table)
 	(error "Not a char-table nor a file name: %s" table)))
   (if (stringp table) (setq table (purecopy table)))
-  (setf (alist-get name char-code-property-alist) table)
-  (put name 'char-code-property-documentation (purecopy docstring)))
+  (if (and (stringp table)
+           (char-table-p (alist-get name char-code-property-alist)))
+      ;; The table is already setup and we're apparently trying to
+      ;; undo that, probably because `charprop.el' is being re-loaded.
+      ;; Just skip it.
+      nil
+    (setf (alist-get name char-code-property-alist) table)
+    (put name 'char-code-property-documentation (purecopy docstring))))
 
 (defvar char-code-property-table
   (make-char-table 'char-code-property-table)

Re: Problem with file-local variables in uni-special-lowercase.el

[Po Lu]

Philipp Stephani <p.stephani2@gmail.com> writes:

> This appears to happen frequently for me as well. Running 'make
> gen-clean' in admin/unidata typically fixes it temporarily.

FWIW, I only saw it after the copyright dates were all updated.
Bootstrapping twice fixed it for me.

Thanks.

Re: Problem with file-local variables in uni-special-lowercase.el

[Stefan Monnier]

> The patch below seems to circumvent the problem.

Oh and I can reproduce it with:

    make
    touch lisp/international/{ucs-normalize,charprop,uni-special-lowercase}.el
    make


-- Stefan

Re: Problem with file-local variables in uni-special-lowercase.el

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 01 Jan 2022 17:52:16 -0500
> 
> I suspect this problem is newly introduced by the symbol-shorthands
> code, which apparently uses just enough more of the `hack-local-variables`
> machinery to trigger it.

Makes sense.

> The patch below seems to circumvent the problem.

Thanks, please install on the emacs-28 branch.