From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-* do fixes (bug#12393)
Date: Tue, 18 Sep 2012 09:37:28 +0300 [thread overview]
Message-ID: <83r4pz25w7.fsf@gnu.org> (raw)
In-Reply-To: <jwvvcfc563g.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Tue, 18 Sep 2012 00:10:16 -0400
> Cc: emacs-devel@gnu.org
>
> > -the given arguments and its return value is returned.
> > +the given arguments. Then we return nil if the function returns nil,
> > +and t if it returns non-nil.
>
> Let's not force ourselves to return t. IOW `non-nil' would be better.
Also, a stylistic issue: we don't normally say "we return" in
documentation, since it's not clear who are "we" in this context.
Something like this would be better:
The value returned is nil if the function returns nil, non-nil
otherwise.
next prev parent reply other threads:[~2012-09-18 6:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1TDmRM-0004cr-78@vcs.savannah.gnu.org>
2012-09-18 4:10 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-* do fixes (bug#12393) Stefan Monnier
2012-09-18 6:37 ` Eli Zaretskii [this message]
2012-09-18 6:55 ` Glenn Morris
2012-09-18 14:20 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24r108143: " Drew Adams
2012-09-18 14:29 ` Eli Zaretskii
2012-09-18 15:20 ` Andreas Schwab
2012-09-18 6:49 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: " Glenn Morris
2012-09-18 12:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r4pz25w7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).