From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-* do fixes (bug#12393) Date: Tue, 18 Sep 2012 09:37:28 +0300 Message-ID: <83r4pz25w7.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347950262 6537 80.91.229.3 (18 Sep 2012 06:37:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2012 06:37:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 18 08:37:47 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TDrRI-0006DK-RO for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2012 08:37:44 +0200 Original-Received: from localhost ([::1]:58896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDrRE-0007hm-Oa for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2012 02:37:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDrRC-0007hV-9X for emacs-devel@gnu.org; Tue, 18 Sep 2012 02:37:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDrR8-00023c-2C for emacs-devel@gnu.org; Tue, 18 Sep 2012 02:37:38 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:41778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDrR7-00022k-QZ; Tue, 18 Sep 2012 02:37:33 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MAJ0070091Z4300@a-mtaout21.012.net.il>; Tue, 18 Sep 2012 09:37:19 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAJ006Q0927ZZ60@a-mtaout21.012.net.il>; Tue, 18 Sep 2012 09:37:19 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153372 Archived-At: > From: Stefan Monnier > Date: Tue, 18 Sep 2012 00:10:16 -0400 > Cc: emacs-devel@gnu.org > > > -the given arguments and its return value is returned. > > +the given arguments. Then we return nil if the function returns nil, > > +and t if it returns non-nil. > > Let's not force ourselves to return t. IOW `non-nil' would be better. Also, a stylistic issue: we don't normally say "we return" in documentation, since it's not clear who are "we" in this context. Something like this would be better: The value returned is nil if the function returns nil, non-nil otherwise.