unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 751789471c: Display pre-edit information from X input methods
Date: Fri, 07 Jan 2022 10:17:59 +0200	[thread overview]
Message-ID: <83r19k558o.fsf@gnu.org> (raw)

> branch: master
> commit 751789471cf04916bcfad358472625f382e596d8
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> 
>     Display pre-edit information from X input methods
>     
>     This also repurposes the `pgtk-preedit-text' event to be
>     meaningful on X, renames it `preedit-text', and documents it.
>     
>     * doc/lispref/commands.texi (Misc Events): Document
>     `preedit-text'.
>     * lisp/term/pgtk-win.el (pgtk-preedit-text): Bind to
>     `preedit-text' instead.
>     * lisp/term/x-win.el (x-preedit-overlay): New variable.
>     (x-preedit-text): New command, bound as a special event to
>     `preedit-text'.

Does this mean we will now display the preedit text from XIM in our
own windows?  And this is on by default, and the user cannot go back
to the old behavior (where AFAIU the preedit text was displayed by the
IM itself)?  Those are all user-visible features, and should be
documented as such.  Currently, there doesn't seem to be any
user-level documentation, and moreover, the lispref documentation
stops short of saying how these new events are used by Emacs.

Also, I believe we should let users go back to previous behavior, and
I'm not yet sure we should make this behavior change by default.

Or what am I missing?



             reply	other threads:[~2022-01-07  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  8:17 Eli Zaretskii [this message]
2022-01-07  9:19 ` master 751789471c: Display pre-edit information from X input methods Po Lu
2022-01-07  9:40   ` Stefan Kangas
2022-01-07 10:46     ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r19k558o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).