From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 751789471c: Display pre-edit information from X input methods Date: Fri, 07 Jan 2022 10:17:59 +0200 Message-ID: <83r19k558o.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 07 09:18:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5kSO-00024q-Et for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 09:18:40 +0100 Original-Received: from localhost ([::1]:56204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5kSN-00015A-9n for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 03:18:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5kRX-0000Ls-Bw for emacs-devel@gnu.org; Fri, 07 Jan 2022 03:17:47 -0500 Original-Received: from [2001:470:142:3::e] (port=39242 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5kRW-0007jb-2Q; Fri, 07 Jan 2022 03:17:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=ryU+ryJFkYMiuE/c6HiRxxoxzwOAOE77vOQkdlcM1WU=; b=Oo6zQEEbkB7ivf Ggcn8Ssb2Rap57Z40H3YbMdd2M4iz/x5ekjUmDjXSLwXwDMOL4cAQAt15JOPw8189R1d8DIbYe0hc Z1FuJtjY31hJXUxdK+rZYop07sqxXV7sZRXJNRAFRPF81FGAyZAfVXMsP6LCFG9rKAZWOiB3Cu6TT Ri3fkKRiLCWJQjC3bK9Eir45HLWEz8MSx6uf+JMHLCefbnfYVizxLUHdoJof9+dbCWO83zmcMOp0X i4gHz2rGC3nRxQABdL8fNEd8Q2jYeMEWPzuyyHRk2Gp8gJdyzU2q82lOJEFLdGO3LiQbQJE9Yu9EG 67JtBv0uzowyrbYf/utg==; Original-Received: from [87.69.77.57] (port=4716 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5kRW-0005yF-0k; Fri, 07 Jan 2022 03:17:46 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284384 Archived-At: > branch: master > commit 751789471cf04916bcfad358472625f382e596d8 > Author: Po Lu > Commit: Po Lu > > Display pre-edit information from X input methods > > This also repurposes the `pgtk-preedit-text' event to be > meaningful on X, renames it `preedit-text', and documents it. > > * doc/lispref/commands.texi (Misc Events): Document > `preedit-text'. > * lisp/term/pgtk-win.el (pgtk-preedit-text): Bind to > `preedit-text' instead. > * lisp/term/x-win.el (x-preedit-overlay): New variable. > (x-preedit-text): New command, bound as a special event to > `preedit-text'. Does this mean we will now display the preedit text from XIM in our own windows? And this is on by default, and the user cannot go back to the old behavior (where AFAIU the preedit text was displayed by the IM itself)? Those are all user-visible features, and should be documented as such. Currently, there doesn't seem to be any user-level documentation, and moreover, the lispref documentation stops short of saying how these new events are used by Emacs. Also, I believe we should let users go back to previous behavior, and I'm not yet sure we should make this behavior change by default. Or what am I missing?