From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org
Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function.
Date: Mon, 05 Jun 2023 14:40:28 +0300 [thread overview]
Message-ID: <83r0qq3zo3.fsf@gnu.org> (raw)
> branch: master
> commit a30781399b3ef48150b9cb13cb0aeba7086c2d9e
> Author: Sean Whitton <spwhitton@spwhitton.name>
> Commit: Sean Whitton <spwhitton@spwhitton.name>
>
> * subr-x (eval-command-interactive-spec): New function.
> ---
> etc/NEWS | 5 +++++
> lisp/emacs-lisp/nadvice.el | 2 ++
> lisp/emacs-lisp/subr-x.el | 7 +++++++
> 3 files changed, 14 insertions(+)
Thanks for working on this, but please document this new function in
the ELisp manual. It is important enough to be mentioned there.
In the future, please always accompany user-visible changes with
suitable changes to one or both of our manuals, to make sure the
manuals are kept up-to-date at all times.
Also, the changeset touches 3 files, but only one of them is mentioned
in the log message; please avoid this in the future. (I'm not really
sure why you needed the change to nadvice.el, FWIW.)
As for the name of the new function: what do people think about
renaming it to eval-interactive-spec? I don't think we need the
"command" part.
next reply other threads:[~2023-06-05 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 11:40 Eli Zaretskii [this message]
2023-06-06 11:10 ` master a30781399b3: * subr-x (eval-command-interactive-spec): New function Sean Whitton
2023-06-06 11:59 ` Eli Zaretskii
2023-06-14 10:18 ` Sean Whitton
2023-06-14 11:35 ` Eli Zaretskii
[not found] <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org>
[not found] ` <20230605073635.19060C00613@vcs2.savannah.gnu.org>
2023-06-05 10:24 ` Philip Kaludercic
2023-06-06 11:10 ` Sean Whitton
2023-06-06 11:25 ` Mattias Engdegård
2023-06-05 16:14 ` Stefan Monnier
2023-06-06 11:18 ` Sean Whitton
2023-06-09 14:39 ` Stefan Monnier
2023-06-14 10:14 ` Sean Whitton
2023-06-14 20:52 ` Stefan Monnier
2023-06-16 7:12 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0qq3zo3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).