From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org
Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function.
Date: Tue, 06 Jun 2023 14:59:40 +0300 [thread overview]
Message-ID: <83r0qo3ioj.fsf@gnu.org> (raw)
In-Reply-To: <87edmog836.fsf@melete.silentflame.com> (message from Sean Whitton on Tue, 06 Jun 2023 12:10:05 +0100)
> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: emacs-devel@gnu.org
> Date: Tue, 06 Jun 2023 12:10:05 +0100
>
> > In the future, please always accompany user-visible changes with
> > suitable changes to one or both of our manuals, to make sure the
> > manuals are kept up-to-date at all times.
>
> I know to do this in general, but in this case the new function is in
> subr-x, and my understanding was that functions in that file are not to
> be documented in any manuals. Are you suggesting I move it to subr.el?
My primary concern is about documenting useful features. In which
files to put the implementation is secondary, from my POV. We don't
need to be 110% consistent in this regard, btw.
> Regarding NEWS, CONTRIBUTE says
>
> There is no need to mention files such as NEWS and MAINTAINERS, or to
> indicate regeneration of files such as 'lib/gnulib.mk', in the
> ChangeLog entry. "There is no need" means you don't have to, but you
> can if you want to.
>
> Should that text perhaps be updated?
Why? the last sentence already covers my request, doesn't it?
> > As for the name of the new function: what do people think about
> > renaming it to eval-interactive-spec? I don't think we need the
> > "command" part.
>
> In that case, what would we rename advice-eval-interactive-spec to, when
> we drop the 'advice-' prefix?
That function exists for quite some time, so renaming it is a much
harder decision.
next prev parent reply other threads:[~2023-06-06 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 11:40 master a30781399b3: * subr-x (eval-command-interactive-spec): New function Eli Zaretskii
2023-06-06 11:10 ` Sean Whitton
2023-06-06 11:59 ` Eli Zaretskii [this message]
2023-06-14 10:18 ` Sean Whitton
2023-06-14 11:35 ` Eli Zaretskii
[not found] <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org>
[not found] ` <20230605073635.19060C00613@vcs2.savannah.gnu.org>
2023-06-05 10:24 ` Philip Kaludercic
2023-06-06 11:10 ` Sean Whitton
2023-06-06 11:25 ` Mattias Engdegård
2023-06-05 16:14 ` Stefan Monnier
2023-06-06 11:18 ` Sean Whitton
2023-06-09 14:39 ` Stefan Monnier
2023-06-14 10:14 ` Sean Whitton
2023-06-14 20:52 ` Stefan Monnier
2023-06-16 7:12 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0qo3ioj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).