From: Eli Zaretskii <eliz@gnu.org>
To: Mike Kupfer <mkupfer@alum.berkeley.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix Subject when forwarding message with 2-line From
Date: Sat, 27 Nov 2021 18:58:32 +0200 [thread overview]
Message-ID: <83pmqly1qf.fsf@gnu.org> (raw)
In-Reply-To: <5817.1638028785@alto> (message from Mike Kupfer on Sat, 27 Nov 2021 07:59:45 -0800)
> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> cc: emacs-devel@gnu.org
> Date: Sat, 27 Nov 2021 07:59:45 -0800
>
> Eli Zaretskii wrote:
>
> > > From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> > > Date: Fri, 26 Nov 2021 17:49:18 -0800
> > >
> > > Hi, is the attached patch to MH-E eligible for emacs-28, or should it go
> > > into master?
> >
> > I don't use MH-E, so I don't know how severe is the problem. Can you
> > tell?
>
> I think the argument for fixing it now is this: if the user doesn't
> notice the problem and fix it before pressing C-c C-c, the attempt to
> forward can fail (e.g., get bounced by the mail server) because of the
> messed-up headers, and the user might have a hard time figuring out what
> happened.
>
> On the other hand, I think 2-line From headers are fairly rare. I don't
> think I've ever hit this bug. Lester (the person thanked in the
> changeset comment) reported seeing it "once in awhile". It's been on
> the MH-E bug list (on SourceForge) since 2012.
Mmm... I guess it's okay to do this on the release branch. Thanks.
prev parent reply other threads:[~2021-11-27 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 1:49 [PATCH] Fix Subject when forwarding message with 2-line From Mike Kupfer
2021-11-27 6:15 ` Eli Zaretskii
2021-11-27 15:59 ` Mike Kupfer
2021-11-27 16:58 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmqly1qf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mkupfer@alum.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).