From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix Subject when forwarding message with 2-line From Date: Sat, 27 Nov 2021 18:58:32 +0200 Message-ID: <83pmqly1qf.fsf@gnu.org> References: <5817.1638028785@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mike Kupfer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 17:59:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mr12p-0002dD-Ru for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 17:59:23 +0100 Original-Received: from localhost ([::1]:59046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mr12o-00037N-FF for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 11:59:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr11v-0002RK-La for emacs-devel@gnu.org; Sat, 27 Nov 2021 11:58:27 -0500 Original-Received: from [2001:470:142:3::e] (port=35956 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr11v-0007uf-5n; Sat, 27 Nov 2021 11:58:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O/hL9mXfcFJKKyXCHvKv7Dsb8S9h1r2nqxA7iIREQa4=; b=VZELkSnKMkbI 1T0WE7d1zO4flpX01QLhld3qFhCXY/tTZAx4gU1hXsJAm2rreoA3vIryqa/dz2i+d4zfRSkOp8g3x 78V8h0zbrmGxmto3p0Q9V5q8oIxPwCa4qeag7MQog9VDyDk2/vAKzlz5YjK+ZfsUeqe1dq0GkEskl k859AbnVO8HlSw8xmT+ETEaLPMdRajr2HegilNDToH/7pOJwIwdunIIcELTg6tqa4e0U6G7Vbu8d/ Z4P3IXXYDcZdaRVyB5paE89T0gdhbk1LvxBUwnbMmUp7lYETxC2wLE0aiMYlIBDdgMsudiFvf0e/o FvtlIVLnDSU1NgL6/Wsf0Q==; Original-Received: from [87.69.77.57] (port=4084 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr11s-0003rR-6o; Sat, 27 Nov 2021 11:58:27 -0500 In-Reply-To: <5817.1638028785@alto> (message from Mike Kupfer on Sat, 27 Nov 2021 07:59:45 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280350 Archived-At: > From: Mike Kupfer > cc: emacs-devel@gnu.org > Date: Sat, 27 Nov 2021 07:59:45 -0800 > > Eli Zaretskii wrote: > > > > From: Mike Kupfer > > > Date: Fri, 26 Nov 2021 17:49:18 -0800 > > > > > > Hi, is the attached patch to MH-E eligible for emacs-28, or should it go > > > into master? > > > > I don't use MH-E, so I don't know how severe is the problem. Can you > > tell? > > I think the argument for fixing it now is this: if the user doesn't > notice the problem and fix it before pressing C-c C-c, the attempt to > forward can fail (e.g., get bounced by the mail server) because of the > messed-up headers, and the user might have a hard time figuring out what > happened. > > On the other hand, I think 2-line From headers are fairly rare. I don't > think I've ever hit this bug. Lester (the person thanked in the > changeset comment) reported seeing it "once in awhile". It's been on > the MH-E bug list (on SourceForge) since 2012. Mmm... I guess it's okay to do this on the release branch. Thanks.