From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Melo <tmdmelo@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Reversed tmm-prompt items when tmm-mid-prompt is nil
Date: Mon, 29 May 2023 15:33:53 +0300 [thread overview]
Message-ID: <83pm6jgvv2.fsf@gnu.org> (raw)
In-Reply-To: <CABpoeKhcfd5X5N1GE5ZmrcC8VpcGH-hZaBtwE45XU5=i6_Zn3w@mail.gmail.com> (message from Thiago Melo on Sun, 28 May 2023 14:59:37 +0000)
> From: Thiago Melo <tmdmelo@gmail.com>
> Date: Sun, 28 May 2023 14:59:37 +0000
>
> Commit #5d844e1 fixed `tmm-prompt' for Emacs 29 (Bug#63754. Thanks,
> Eli!) and even made the `tmm-mid-prompt' = nil option work again.
AFAICT, this was broken ever since Emacs 22.1, when someone
"optimized" a regexp without paying attention to the possibility of
tmm-mid-prompt being nil.
> The fix also surfaced one inconsistency between nil and non-nil
> `tmm-mid-prompt'. When nil, the items shown by `tmm-prompt' are
> reversed.
>
> Compare these two cases:
>
>
> (let ((tmm-mid-prompt "==>")
> (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3)))))
> (tmm-prompt test-menu))
>
> (let ((tmm-mid-prompt nil)
> (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3)))))
> (tmm-prompt test-menu))
>
>
> It seems innocuous and not worth a bug report. Still, here's a way to
> make this behavior more consistent:
Thanks, I installed a somewhat simpler version of this on the emacs-29
branch.
next prev parent reply other threads:[~2023-05-29 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 14:59 Reversed tmm-prompt items when tmm-mid-prompt is nil Thiago Melo
2023-05-29 12:33 ` Eli Zaretskii [this message]
2023-05-29 14:40 ` Thiago Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm6jgvv2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tmdmelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).