From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reversed tmm-prompt items when tmm-mid-prompt is nil Date: Mon, 29 May 2023 15:33:53 +0300 Message-ID: <83pm6jgvv2.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19863"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thiago Melo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 29 14:34:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3c4r-000311-GR for ged-emacs-devel@m.gmane-mx.org; Mon, 29 May 2023 14:34:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3c3p-0007o5-2t; Mon, 29 May 2023 08:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3c3n-0007nf-Cp for emacs-devel@gnu.org; Mon, 29 May 2023 08:33:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3c3n-0001vP-1L; Mon, 29 May 2023 08:33:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wpGUPcfH4Ss7MuSA71AC00yKf3rDNb/cj5yExO6YDwc=; b=HPid6YepduCI ExFZ2GFBWj6Nu21J2sUoC/kR4AcSi7MTXnyj4plU8Bljp0zw77cUvrauo6faWpvKHZvJwdG4BnvPD pmj8++sTPUShlP71q8yhQwa+Xa7UsCGpDpElqNiiXIeJ0fSEKebAbW/FMJDrxHdBmKG7Q1OuoHWZG H/OLV+RahgQIWzYlaeoc5U3QIIysyIp/MoyGll5KggiwHveP/6vQrMHowl2BkBFUFAdutXzTK3ZE5 47yuWI4Djr1AxNvkEAnSv7C7WlOXyuQVUyoms05xidYMBaguN+C0yOVXj2JEHxrxVGWgKBPGrW9Fh blic1NnnVXaMplaclcFtaA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3c3m-0001Hn-FK; Mon, 29 May 2023 08:33:14 -0400 In-Reply-To: (message from Thiago Melo on Sun, 28 May 2023 14:59:37 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308077 > From: Thiago Melo > Date: Sun, 28 May 2023 14:59:37 +0000 > > Commit #5d844e1 fixed `tmm-prompt' for Emacs 29 (Bug#63754. Thanks, > Eli!) and even made the `tmm-mid-prompt' = nil option work again. AFAICT, this was broken ever since Emacs 22.1, when someone "optimized" a regexp without paying attention to the possibility of tmm-mid-prompt being nil. > The fix also surfaced one inconsistency between nil and non-nil > `tmm-mid-prompt'. When nil, the items shown by `tmm-prompt' are > reversed. > > Compare these two cases: > > > (let ((tmm-mid-prompt "==>") > (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3))))) > (tmm-prompt test-menu)) > > (let ((tmm-mid-prompt nil) > (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3))))) > (tmm-prompt test-menu)) > > > It seems innocuous and not worth a bug report. Still, here's a way to > make this behavior more consistent: Thanks, I installed a somewhat simpler version of this on the emacs-29 branch.