Warnings building master

Warnings building master

[Andy Moreton]

Building emacs master on Windows (msys2 64bit with gcc 10.3.0) now
generates the following warnings:

  CC       image.o
C:/emacs/git/emacs/master/src/image.c:7788:1: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
 7788 | DEF_DLL_FN (int, TIFFReadRGBAImage, (TIFF *, uint32, uint32, uint32 *, int));
      | ^~~~~~~~~~
C:/emacs/git/emacs/master/src/image.c:7788:1: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
C:/emacs/git/emacs/master/src/image.c:7788:1: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
C:/emacs/git/emacs/master/src/image.c: In function 'tiff_load':
C:/emacs/git/emacs/master/src/image.c:7980:3: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
 7980 |   uint32 *buf;
      |   ^~~~~~
C:/emacs/git/emacs/master/src/image.c:8106:7: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
 8106 |       uint32 *row = buf + y * width;
      |       ^~~~~~
C:/emacs/git/emacs/master/src/image.c:8110:4: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
 8110 |    uint32 abgr = row[x];
      |    ^~~~~~

It appears that this code needs to be updated to use C99 integer types.

    AndyM

Re: Warnings building master

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 14 Jul 2021 00:39:56 +0100
> 
> 
> Building emacs master on Windows (msys2 64bit with gcc 10.3.0) now
> generates the following warnings:

What does "now" mean?  What changed on your system that started
triggering these warnings?  Was that GCC? or system libraries/headers?
or libTIFF? or something else?  Since that code hasn't changed in
eons, it's most probably some change on your system.

Re: Warnings building master

[Kévin Le Gouguec]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Wed, 14 Jul 2021 00:39:56 +0100
>> 
>> 
>> Building emacs master on Windows (msys2 64bit with gcc 10.3.0) now
>> generates the following warnings:
>
> What does "now" mean?  What changed on your system that started
> triggering these warnings?  Was that GCC? or system libraries/headers?
> or libTIFF? or something else?  Since that code hasn't changed in
> eons, it's most probably some change on your system.

I've started seeing these warnings "recently-ish" too, on openSUSE
Tumbleweed (libtiff-devel 4.3.0).  Following the include chain
(image.c > tiffio.h > tiff.h), I see this:

> typedef TIFF_MSC_DEPRECATED uint32_t uint32 TIFF_GCC_DEPRECATED;

This seems to have been added 5 months ago:

https://gitlab.com/libtiff/libtiff/-/commit/ddb8756f10520396f09d9c86f740013a69b82e08

Re: Warnings building master

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Andy Moreton <andrewjmoreton@gmail.com>,  emacs-devel@gnu.org
> Date: Wed, 14 Jul 2021 11:12:43 +0200
> 
> I've started seeing these warnings "recently-ish" too, on openSUSE
> Tumbleweed (libtiff-devel 4.3.0).  Following the include chain
> (image.c > tiffio.h > tiff.h), I see this:
> 
> > typedef TIFF_MSC_DEPRECATED uint32_t uint32 TIFF_GCC_DEPRECATED;
> 
> This seems to have been added 5 months ago:
> 
> https://gitlab.com/libtiff/libtiff/-/commit/ddb8756f10520396f09d9c86f740013a69b82e08

Thanks, I've now tried to fix these warnings on master.

Re: Warnings building master

[Kévin Le Gouguec]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, I've now tried to fix these warnings on master.

Thanks!  image.c compiles cleanly now, on my end at least.

Re: Warnings building master

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Date: Wed, 14 Jul 2021 16:36:25 +0200
> Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks, I've now tried to fix these warnings on master.
> 
> Thanks!  image.c compiles cleanly now, on my end at least.

Thanks for testing the fix.

Re: Warnings building master

[Andy Moreton]

On Wed 14 Jul 2021, Eli Zaretskii wrote:

>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Wed, 14 Jul 2021 16:36:25 +0200
>> Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Thanks, I've now tried to fix these warnings on master.
>> 
>> Thanks!  image.c compiles cleanly now, on my end at least.
>
> Thanks for testing the fix.

Thanks Eli, the warnings are gone. Apologies for not noting
carefully when these warnings first appeared.

    AndyM

Re: Warnings building master

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 14 Jul 2021 20:38:55 +0100
> 
> >> Thanks!  image.c compiles cleanly now, on my end at least.
> >
> > Thanks for testing the fix.
> 
> Thanks Eli, the warnings are gone. Apologies for not noting
> carefully when these warnings first appeared.

No sweat.  Thanks for testing the fix, I more or less made it flying
blind.