[ELPA] Add fontaine package?

[ELPA] Add fontaine package?

[Protesilaos Stavrou]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hello everyone,

I have a new package called "fontaine" that I would like to offer to the
FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
is similar to the 'cursory' package I submitted last week: the user
defines presets of font configurations and can switch between them on
demand.

This can be useful for someone who, for example, likes compact fonts
while typing and more spacious ones for reading or doing a presentation.

Do you think this can be added to the package archive?  Any further
comments?

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elpa-packages-fontaine-New-package.patch --]
[-- Type: text/x-patch, Size: 907 bytes --]

From 70c53ac5a776978615d6f541a7feaf70b717c327 Mon Sep 17 00:00:00 2001
Message-Id: <70c53ac5a776978615d6f541a7feaf70b717c327.1651045742.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Wed, 27 Apr 2022 10:47:32 +0300
Subject: [PATCH] * elpa-packages (fontaine): New package

---
 elpa-packages | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 06003bc5fb..98a9838d18 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -285,6 +285,10 @@
  ("flymake"		:core "lisp/progmodes/flymake.el")
  ("flymake-proselint"	:url "https://git.sr.ht/~manuel-uberti/flycheck-proselint"
   :auto-sync t)
+ ("fontaine"
+  :url "https://git.sr.ht/~protesilaos/fontaine"
+  :auto-sync t
+  :ignored-files ("COPYING" "doclicense.texi"))
  ("frame-tabs"		:url nil)
  ("frog-menu"		:url "https://github.com/clemera/frog-menu")
  ("fsm"			:url nil)
-- 
2.36.0

Re: [ELPA] Add fontaine package?

[Stefan Monnier]

Protesilaos Stavrou [2022-04-27 11:03:23] wrote:
> I have a new package called "fontaine" that I would like to offer to the
> FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
> is similar to the 'cursory' package I submitted last week: the user
> defines presets of font configurations and can switch between them on
> demand.

Any reason why you don't represent these choices as Custom themes?

> Do you think this can be added to the package archive?

No objection on my side.


        Stefan

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 27 Apr 2022 13:00:48 -0400
>
> Protesilaos Stavrou [2022-04-27 11:03:23] wrote:
>> I have a new package called "fontaine" that I would like to offer to the
>> FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
>> is similar to the 'cursory' package I submitted last week: the user
>> defines presets of font configurations and can switch between them on
>> demand.
>
> Any reason why you don't represent these choices as Custom themes?

I had not thought about it.  I shall explore this option going forward.

>> Do you think this can be added to the package archive?
>
> No objection on my side.

Thank you!  I will install the patch now.

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [ELPA] Add fontaine package?

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I have a new package called "fontaine" that I would like to offer to the
  > FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
  > is similar to the 'cursory' package I submitted last week: the user
  > defines presets of font configurations and can switch between them on
  > demand.

What's the difference between them?  What feature does fontaine
offer, tht cursory doesn't have?

Could that feature be added as an option to cursory?


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Richard Stallman <rms@gnu.org>
> Date: Wed, 27 Apr 2022 23:18:45 -0400
>
>   > I have a new package called "fontaine" that I would like to offer to the
>   > FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
>   > is similar to the 'cursory' package I submitted last week: the user
>   > defines presets of font configurations and can switch between them on
>   > demand.
>
> What's the difference between them?  What feature does fontaine
> offer, tht cursory doesn't have?

Cursory ultimately applies configurations to variables such as
'cursor-type' and 'blink-cursor-delay'.  Whereas Fontaine changes the
typographic attributes of faces like 'default' and 'fixed-pitch'.  By
"typographic attributes", I mean the ':family', ':height', ':weight'.

> Could that feature be added as an option to cursory?

I think it is better to keep the two feature sets separate.  It makes
things easier to maintain and more straightforward to document.  I can,
however, update the documentation in each package to reference the
other.

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [ELPA] Add fontaine package?

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Wed, 27 Apr 2022 11:03:23 +0300
> 
> I have a new package called "fontaine" that I would like to offer to the
> FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
> is similar to the 'cursory' package I submitted last week: the user
> defines presets of font configurations and can switch between them on
> demand.
> 
> This can be useful for someone who, for example, likes compact fonts
> while typing and more spacious ones for reading or doing a presentation.
> 
> Do you think this can be added to the package archive?  Any further
> comments?

I have some comments on the package's code:

 . It uses internal-set-lisp-face-attribute, which is an internal
   primitive, something I'd suggest to avoid.  Why can't it use
   set-lisp-face-attribute instead?
 . For some reason, customization of the bold-italic face is not
   supported, whereas that of bold and italic is supported.  Why is
   that?
 . The documentation should IMO explain that the font settings are
   only for the ASCII characters; for non-ASCII characters Emacs will
   still use fonts from the fontset, which probably belong to
   different families.
 . Specifying default weight that is other than 'normal'/'regular',
   'bold', or 'italic' will not work on MS-Windows.  I think this
   should be at least documented.
 . On MS-Windows, fontaine--family-list-variable-pitch returns nil,
   whereas fontaine--family-list-fixed-pitch returns a list of font
   families that include both fixed-pitch and variable-pitch fonts.
   That was due to a bug (which is now fixed on master), but this will
   not work reliably in older versions of Emacs.
 . IME, the list of fonts returned by x-family-fonts may include fonts
   that aren't appropriate for use by Emacs, so caveat emptor.

Thanks.

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 28 Apr 2022 10:57:19 +0300
>
>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Date: Wed, 27 Apr 2022 11:03:23 +0300
>> 
>> I have a new package called "fontaine" that I would like to offer to the
>> FSF for inclusion in GNU ELPA (see attached patch).  Conceptually, this
>> is similar to the 'cursory' package I submitted last week: the user
>> defines presets of font configurations and can switch between them on
>> demand.
>> 
>> This can be useful for someone who, for example, likes compact fonts
>> while typing and more spacious ones for reading or doing a presentation.
>> 
>> Do you think this can be added to the package archive?  Any further
>> comments?
>
> I have some comments on the package's code:

Thank you!

>  . It uses internal-set-lisp-face-attribute, which is an internal
>    primitive, something I'd suggest to avoid.  Why can't it use
>    set-lisp-face-attribute instead?

I do not have 'set-lisp-face-attribute' on my end (Emacs 29, GNU/Linux).
I ran a grep in the emacs.git repo and still did not find it.  It
returns this:

    lisp/ChangeLog.14:10815:	(internal-set-lisp-face-attribute-from-resource, x-bitmap-file-path)
    lisp/ChangeLog.15:13166:	internal-set-lisp-face-attribute with 'unspecified family and
    lisp/ChangeLog.9:12148:	internal-set-lisp-face-attribute with FRAME being 0.
    lisp/faces.el:384:(declare-function internal-set-lisp-face-attribute-from-resource "xfaces.c"
    lisp/faces.el:397:	  (internal-set-lisp-face-attribute-from-resource
    lisp/faces.el:860:	(internal-set-lisp-face-attribute face :family (purecopy family)
    lisp/faces.el:863:	(internal-set-lisp-face-attribute face :foundry (purecopy foundry)
    lisp/faces.el:867:	(internal-set-lisp-face-attribute face (car args)
    src/ChangeLog.11:6863:	internal-set-lisp-face-attribute.  Initialize screen colors from
    src/xfaces.c:3011:DEFUN ("internal-set-lisp-face-attribute", Finternal_set_lisp_face_attribute,
    src/xfaces.c:3780:DEFUN ("internal-set-lisp-face-attribute-from-resource",

Otherwise I am happy to follow your suggestion.

>  . For some reason, customization of the bold-italic face is not
>    supported, whereas that of bold and italic is supported.  Why is
>    that?

I will cover it as well.

>  . The documentation should IMO explain that the font settings are
>    only for the ASCII characters; for non-ASCII characters Emacs will
>    still use fonts from the fontset, which probably belong to
>    different families.

Indeed.  Perhaps a future version of the package could extend to
fontsets, but that needs to be considered.

>  . Specifying default weight that is other than 'normal'/'regular',
>    'bold', or 'italic' will not work on MS-Windows.  I think this
>    should be at least documented.

I did not know that.  Will cover it in the documentation.

>  . On MS-Windows, fontaine--family-list-variable-pitch returns nil,
>    whereas fontaine--family-list-fixed-pitch returns a list of font
>    families that include both fixed-pitch and variable-pitch fonts.
>    That was due to a bug (which is now fixed on master), but this will
>    not work reliably in older versions of Emacs.

Is there something we can do about this beside documenting it?

>  . IME, the list of fonts returned by x-family-fonts may include fonts
>    that aren't appropriate for use by Emacs, so caveat emptor.

I expected as much.  Is there some way to find only the appropriate
ones?  Otherwise I will clarify this point in the docs.

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [ELPA] Add fontaine package?

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 28 Apr 2022 11:23:56 +0300
> 
> >  . It uses internal-set-lisp-face-attribute, which is an internal
> >    primitive, something I'd suggest to avoid.  Why can't it use
> >    set-lisp-face-attribute instead?
> 
> I do not have 'set-lisp-face-attribute' on my end (Emacs 29, GNU/Linux).

Sorry, I meant set-face-attribute, of course.

> >  . On MS-Windows, fontaine--family-list-variable-pitch returns nil,
> >    whereas fontaine--family-list-fixed-pitch returns a list of font
> >    families that include both fixed-pitch and variable-pitch fonts.
> >    That was due to a bug (which is now fixed on master), but this will
> >    not work reliably in older versions of Emacs.
> 
> Is there something we can do about this beside documenting it?

On older versions of Emacs, only if you manually test each font for
being fixed-pitch, instead of relying on x-family-fonts to do that
correctly.  See the change I did in artist.el for how this could be
done.

> >  . IME, the list of fonts returned by x-family-fonts may include fonts
> >    that aren't appropriate for use by Emacs, so caveat emptor.
> 
> I expected as much.  Is there some way to find only the appropriate
> ones?

I found in the past that the following produces reasonable results:

  (delete-dups
    (x-list-fonts "-*-*-medium-r-normal-*-*-*-*-*-*-iso10646-1" 'default frame))

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 28 Apr 2022 12:41:10 +0300
>
>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 28 Apr 2022 11:23:56 +0300
>> 
>> >  . It uses internal-set-lisp-face-attribute, which is an internal
>> >    primitive, something I'd suggest to avoid.  Why can't it use
>> >    set-lisp-face-attribute instead?
>> 
>> I do not have 'set-lisp-face-attribute' on my end (Emacs 29, GNU/Linux).
>
> Sorry, I meant set-face-attribute, of course.

The reason I did not use it is due to what we discussed in bug#45920.
Basically, set-face-attribute needs to be evaluated twice when (i) we
change the :family, (ii) change the :weight, and (iii) the new family
does not have the weight of the previous one.

The example I used in that bug report, which I can still reproduce with
emacs -Q:

   ;; Sample 1
   (set-face-attribute 'default nil
                       :family "Source Code Pro"
                       :weight 'light)

   ;; Sample 2
   (set-face-attribute 'default nil
                       :family "Hack"
                       :weight 'normal)

Evaluate sample 1.  It works.  Now evaluate sample 2.  Notice that it
does not yield the expected result.  Evaluate sample 2 again: the result
is the desired one.

By using internal-set-lisp-face-attribute, I specify the sequence of
events that always works.

Perhaps there is a better way to handle this edge case?

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [ELPA] Add fontaine package?

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 29 Apr 2022 10:02:16 +0300
> 
> >> >  . It uses internal-set-lisp-face-attribute, which is an internal
> >> >    primitive, something I'd suggest to avoid.  Why can't it use
> >> >    set-lisp-face-attribute instead?
> >> 
> >> I do not have 'set-lisp-face-attribute' on my end (Emacs 29, GNU/Linux).
> >
> > Sorry, I meant set-face-attribute, of course.
> 
> The reason I did not use it is due to what we discussed in bug#45920.
> Basically, set-face-attribute needs to be evaluated twice when (i) we
> change the :family, (ii) change the :weight, and (iii) the new family
> does not have the weight of the previous one.
> 
> The example I used in that bug report, which I can still reproduce with
> emacs -Q:
> 
>    ;; Sample 1
>    (set-face-attribute 'default nil
>                        :family "Source Code Pro"
>                        :weight 'light)
> 
>    ;; Sample 2
>    (set-face-attribute 'default nil
>                        :family "Hack"
>                        :weight 'normal)
> 
> Evaluate sample 1.  It works.  Now evaluate sample 2.  Notice that it
> does not yield the expected result.  Evaluate sample 2 again: the result
> is the desired one.
> 
> By using internal-set-lisp-face-attribute, I specify the sequence of
> events that always works.
> 
> Perhaps there is a better way to handle this edge case?

What exactly is the "edge case", and why do you need it in this
package?

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 29 Apr 2022 10:15:33 +0300
>
>> > Sorry, I meant set-face-attribute, of course.
>> 
>> The reason I did not use it is due to what we discussed in bug#45920.
>> Basically, set-face-attribute needs to be evaluated twice when (i) we
>> change the :family, (ii) change the :weight, and (iii) the new family
>> does not have the weight of the previous one.
>> 
>> The example I used in that bug report, which I can still reproduce with
>> emacs -Q:
>> 
>>    ;; Sample 1
>>    (set-face-attribute 'default nil
>>                        :family "Source Code Pro"
>>                        :weight 'light)
>> 
>>    ;; Sample 2
>>    (set-face-attribute 'default nil
>>                        :family "Hack"
>>                        :weight 'normal)
>> 
>> Evaluate sample 1.  It works.  Now evaluate sample 2.  Notice that it
>> does not yield the expected result.  Evaluate sample 2 again: the result
>> is the desired one.
>> 
>> By using internal-set-lisp-face-attribute, I specify the sequence of
>> events that always works.
>> 
>> Perhaps there is a better way to handle this edge case?
>
> What exactly is the "edge case", and why do you need it in this
> package?

It is possible to have a typeface that has a light weight and another
that hasn't.  If the user defines two presets in fontaine-presets and
tries to switch from the one with the light weight to the other without
it, they will encounter the aforementioned behaviour of
set-face-attribute.

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [ELPA] Add fontaine package?

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 29 Apr 2022 10:23:52 +0300
> 
> It is possible to have a typeface that has a light weight and another
> that hasn't.  If the user defines two presets in fontaine-presets and
> tries to switch from the one with the light weight to the other without
> it, they will encounter the aforementioned behaviour of
> set-face-attribute.

Did you try using set-face-font instead?  Its FONT argument can be a
font-spec, so you should be able to say things like

  (set-face-font 'default (font-spec :family "Hack" :weight 'light))

and get what you want, I think.

Re: [ELPA] Add fontaine package?

[Protesilaos Stavrou]

> From: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 29 Apr 2022 10:40:38 +0300
>
>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 29 Apr 2022 10:23:52 +0300
>> 
>> It is possible to have a typeface that has a light weight and another
>> that hasn't.  If the user defines two presets in fontaine-presets and
>> tries to switch from the one with the light weight to the other without
>> it, they will encounter the aforementioned behaviour of
>> set-face-attribute.
>
> Did you try using set-face-font instead?  Its FONT argument can be a
> font-spec, so you should be able to say things like
>
>   (set-face-font 'default (font-spec :family "Hack" :weight 'light))
>
> and get what you want, I think.

Very well!  I will try this approach and change things accordingly.

-- 
Protesilaos Stavrou
https://protesilaos.com