From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: master 2772ebe366: Do not prune native-compiled system directories (bug#59658)
Date: Thu, 01 Dec 2022 09:18:43 +0200 [thread overview]
Message-ID: <83mt87iobw.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmn-Xncc0fEK3KC3FBV==eEu9cZ1OdrmFp9PVeJ0=k9YYQ@mail.gmail.com> (message from Stefan Kangas on Wed, 30 Nov 2022 19:49:25 -0800)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 30 Nov 2022 19:49:25 -0800
> Cc: emacs-devel@gnu.org
>
> Juanma Barranquero <lekktu@gmail.com> writes:
>
> > Yes, I see. We'll have to decide where's the error, or what's the intended
> > behavior.
>
> The point of the command is basically to free some disk space by getting
> rid of (presumably unused) files from ~/.emacs.d/eln-cache.
>
> > 1.- We fix the test so it sets native-comp-eln-load-path to a list of two
> > directories, and checks that the stale subdir is deleted in the first, and
> > nothing is deleted in the second ("system") one.
>
> I don't really have an opinion on the rest, so just fixing the test
> sounds like an okay outcome from my perspective.
I agree that we should fix the test, not what the command does.
next prev parent reply other threads:[~2022-12-01 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166965402487.18442.18379860639913355185@vcs2.savannah.gnu.org>
[not found] ` <20221128164705.366A7C004B6@vcs2.savannah.gnu.org>
2022-11-30 17:34 ` master 2772ebe366: Do not prune native-compiled system directories (bug#59658) Stefan Kangas
2022-12-01 1:05 ` Juanma Barranquero
2022-12-01 3:49 ` Stefan Kangas
2022-12-01 3:57 ` Juanma Barranquero
2022-12-01 7:18 ` Eli Zaretskii [this message]
2022-12-01 16:56 ` Juanma Barranquero
2022-12-03 11:25 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt87iobw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).