From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2772ebe366: Do not prune native-compiled system directories (bug#59658) Date: Thu, 01 Dec 2022 09:18:43 +0200 Message-ID: <83mt87iobw.fsf@gnu.org> References: <166965402487.18442.18379860639913355185@vcs2.savannah.gnu.org> <20221128164705.366A7C004B6@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 01 08:19:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0drR-00044w-Js for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Dec 2022 08:19:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0dqs-0007aF-HB; Thu, 01 Dec 2022 02:19:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0dqm-0007XN-Fb for emacs-devel@gnu.org; Thu, 01 Dec 2022 02:19:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0dqk-0003U6-01; Thu, 01 Dec 2022 02:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=68l8t/4ZrN5Ou7QVgpBb0e+XqlMZ+PwTrQ19w7nMgGs=; b=BdfVLcJNcBV5 m0lOOgaFXKbZWIBq9cfkwJKVL0DMqMVnyiNarNSOpIEDAjtPJJbmLiY3ITPMUvOqboy1frl+Wf0Ej DSwuWqJtucNYgbNxuuYcT0xpAVLrx/YwJ7rSX0z5WhWA4SjwbYRGBCVsCpIwz5+TwsEAE26RKNXIl Y47KGEvO58e7BzhVrmn/o9L5BxCPofEcShSqGxVcJt9Xw8vg1ILq9tY+4o+dgeo3hJy++Wo4XfxIC HItZoB+p8Kw2u0/BaSn/Y6sJXCxIUP8J6BKp4lvrrb21f46X4sf39rQOwWqUFhtNZbR+Z1CNYHWMV /6ikkgdMuc1SdhJNQzLYlA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0dqi-00062y-C3; Thu, 01 Dec 2022 02:19:12 -0500 In-Reply-To: (message from Stefan Kangas on Wed, 30 Nov 2022 19:49:25 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300803 Archived-At: > From: Stefan Kangas > Date: Wed, 30 Nov 2022 19:49:25 -0800 > Cc: emacs-devel@gnu.org > > Juanma Barranquero writes: > > > Yes, I see. We'll have to decide where's the error, or what's the intended > > behavior. > > The point of the command is basically to free some disk space by getting > rid of (presumably unused) files from ~/.emacs.d/eln-cache. > > > 1.- We fix the test so it sets native-comp-eln-load-path to a list of two > > directories, and checks that the stale subdir is deleted in the first, and > > nothing is deleted in the second ("system") one. > > I don't really have an opinion on the rest, so just fixing the test > sounds like an okay outcome from my perspective. I agree that we should fix the test, not what the command does.