unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org, pedz@easesoftware.com, monnier@IRO.UMontreal.CA
Subject: Re: Cutoff date for adding ruby-ts-mode?
Date: Fri, 30 Dec 2022 18:59:04 +0200	[thread overview]
Message-ID: <83mt746d5z.fsf@gnu.org> (raw)
In-Reply-To: <9fd271e5-5501-83de-0185-27a3c40eed26@yandex.ru> (message from Dmitry Gutov on Fri, 30 Dec 2022 17:32:47 +0200)

> Date: Fri, 30 Dec 2022 17:32:47 +0200
> Cc: emacs-devel@gnu.org, pedz@easesoftware.com,
>  Stefan Monnier <monnier@IRO.UMontreal.CA>
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> Speaking of the method, how do you feel about renaming a file?
> 
> If ruby-ts-mode is going to live in the same file as ruby-mode, perhaps 
> the more neutral file name ruby.el would be proper? This would be in 
> line with the scheme used by js.el and python.el.

I'd like to avoid any more decisions related to *-ts-mode's, let alone
binding ones.  I'd like to leave that for the future, when we
(hopefully) will have a clearer picture of how best to mix
tree-sitter-supported modes with the traditional ones.

So renaming now doesn't sound like a good idea to me.

> This is not an idle lets-decide-it-later question because I want to have 
> some later releases of these modes in GNU ELPA, and we'll want to have 
> the built-in packages properly shadowed when someone installs a new 
> version. (Perhaps Stefan has an advice here, so Cc'd).
> 
> I see several (require 'ruby-mode)-s in third-party packages. There are 
> not too many of them, I could just go around and ask everyone to replace 
> that with (or (require 'ruby nil t) (require 'ruby-mode)). Or we could 
> have a compatibility stub in Emacs 29 where ruby-mode.el just calls 
> "(require 'ruby) (provide 'ruby-mode)".
> 
> We don't often rename files also because of 'git log' problems, but we 
> have a decent (and simple enough) plan to improve that in bug#55871.
> 
> Alternatively, we break from the common scheme and put the modes in 
> separate files, one depending on the other. Then they'll have to be 
> separate GNU ELPA packages (I think), and we'll need to synchronously 
> bump version and required-version in them every time when making 
> interrelated changes in the future.

I'd prefer this alternative for now (modulo the separate ELPA packages
part, which I leave for you to decide: they could also be a single
package from my POV).  If nothing else, having separate files is
similar to what at least some other *-ts-mode's do.  When we revisit
these issues in the future, we'll be able to make the decisions about
all of them.

Thanks.



  reply	other threads:[~2022-12-30 16:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 21:39 Cutoff date for adding ruby-ts-mode? Dmitry Gutov
2022-12-30  8:16 ` Eli Zaretskii
2022-12-30 15:32   ` Dmitry Gutov
2022-12-30 16:59     ` Eli Zaretskii [this message]
2022-12-30 21:42       ` Dmitry Gutov
2022-12-31  6:31         ` Eli Zaretskii
2022-12-31 11:24         ` Stefan Kangas
2023-01-02  1:35   ` Dmitry Gutov
2023-01-02 12:51     ` Eli Zaretskii
2023-01-02 18:44       ` Juri Linkov
2023-01-03  1:22         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mt746d5z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=pedz@easesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).