From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Cutoff date for adding ruby-ts-mode? Date: Fri, 30 Dec 2022 18:59:04 +0200 Message-ID: <83mt746d5z.fsf@gnu.org> References: <00b1ed5e-271b-fab7-cace-b6a04ac6fd46@yandex.ru> <83mt7571cu.fsf@gnu.org> <9fd271e5-5501-83de-0185-27a3c40eed26@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17616"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, pedz@easesoftware.com, monnier@IRO.UMontreal.CA To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 30 17:59:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBIjL-0004Si-EC for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Dec 2022 17:59:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBIis-0001F0-25; Fri, 30 Dec 2022 11:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBIiq-0001EZ-2k for emacs-devel@gnu.org; Fri, 30 Dec 2022 11:59:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBIio-00020d-TR; Fri, 30 Dec 2022 11:59:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vR+YdT6UomH3nJbvDPkYWIyezKG4sTDV9+QvHl4VR9Q=; b=D22lI4rAXQEo k+x5qZ24mD5G1DUWymi5gkKk6kvoe30DbLHpU8Y0PS+CpRqcC1MlU0oLOVqVu0sKB37dy/4RSHpNf oTyM2UQy9flTumYAEOn0Ti8NDWpR0TGnFagTMt61fgn4CmCZPZCIOB474eCpE9ZrifYK0ptGxIm3h a6vaATpi27avpjxfbZpuet5oJPz7F4KnZ9A8uzb2CsW+Mj9kdmtqVQzr6evIoKEHAXT9PpRbwaUjl 4Q+1tcRgYwiKvpmZFysybXmRM1TBVBw1dH5tJZ2M57rmW3BXWcpyYwBLSYqbQrzIpBkUXFpalRD++ R+CEwc8IBHiJdfa7AiPuyA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBIio-00026h-DI; Fri, 30 Dec 2022 11:59:06 -0500 In-Reply-To: <9fd271e5-5501-83de-0185-27a3c40eed26@yandex.ru> (message from Dmitry Gutov on Fri, 30 Dec 2022 17:32:47 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302130 Archived-At: > Date: Fri, 30 Dec 2022 17:32:47 +0200 > Cc: emacs-devel@gnu.org, pedz@easesoftware.com, > Stefan Monnier > From: Dmitry Gutov > > Speaking of the method, how do you feel about renaming a file? > > If ruby-ts-mode is going to live in the same file as ruby-mode, perhaps > the more neutral file name ruby.el would be proper? This would be in > line with the scheme used by js.el and python.el. I'd like to avoid any more decisions related to *-ts-mode's, let alone binding ones. I'd like to leave that for the future, when we (hopefully) will have a clearer picture of how best to mix tree-sitter-supported modes with the traditional ones. So renaming now doesn't sound like a good idea to me. > This is not an idle lets-decide-it-later question because I want to have > some later releases of these modes in GNU ELPA, and we'll want to have > the built-in packages properly shadowed when someone installs a new > version. (Perhaps Stefan has an advice here, so Cc'd). > > I see several (require 'ruby-mode)-s in third-party packages. There are > not too many of them, I could just go around and ask everyone to replace > that with (or (require 'ruby nil t) (require 'ruby-mode)). Or we could > have a compatibility stub in Emacs 29 where ruby-mode.el just calls > "(require 'ruby) (provide 'ruby-mode)". > > We don't often rename files also because of 'git log' problems, but we > have a decent (and simple enough) plan to improve that in bug#55871. > > Alternatively, we break from the common scheme and put the modes in > separate files, one depending on the other. Then they'll have to be > separate GNU ELPA packages (I think), and we'll need to synchronously > bump version and required-version in them every time when making > interrelated changes in the future. I'd prefer this alternative for now (modulo the separate ELPA packages part, which I leave for you to decide: they could also be a single package from my POV). If nothing else, having separate files is similar to what at least some other *-ts-mode's do. When we revisit these issues in the future, we'll be able to make the decisions about all of them. Thanks.