unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Unsafe local variable in eglot.el
Date: Thu, 09 Mar 2023 10:00:52 +0200	[thread overview]
Message-ID: <83mt4m2w23.fsf@gnu.org> (raw)

João,

This recent change:

  commit 0a4b1c0102d4062d24e19340f863b9df25e07ab3
  Author:     Joao Távora <joaotavora@gmail.com>
  AuthorDate: Wed Mar 1 13:24:07 2023 +0000
  Commit:     Joao Távora <joaotavora@gmail.com>
  CommitDate: Wed Mar 1 13:27:06 2023 +0000

      ; Eglot: improve bug-reference-url-format/bug-reference-url-regexp

      * lisp/progmodes/eglot.el (eglot--debbugs-or-github-bug-uri): New helper.

causes trouble when visiting eglot.el.

First, this pops up the "variable may not be safe" buffer about the
variable bug-reference-url-format, even if I use Emacs 29, let alone
if I use older Emacs versions.

And second, if I say "y" to the "apply unsafe variable" prompt, then
with the following jit-lock settings:

  (setq jit-lock-stealth-time 16)
  (setq jit-lock-stealth-nice 0.5)
  (setq jit-lock-stealth-verbose t)
  (setq jit-lock-defer-contextually t)
  (setq jit-lock-stealth-load 20)

I get an error from jit-lock-stealth's timer:

  Error running timer ‘jit-lock-stealth-fontify’: (void-function eglot--debbugs-or-github-bug-uri)

The only way of avoiding these two issues is to say "n" to the prompt
asking whether to apply the variable, but that's not really a good
workaround, is it?

Can these problems be solved, please, preferably in a way that older
Emacsen will also be happy (since Eglot is an ELPA package)?



             reply	other threads:[~2023-03-09  8:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  8:00 Eli Zaretskii [this message]
2023-03-09  9:31 ` Unsafe local variable in eglot.el João Távora
2023-03-09 11:24   ` João Távora
2023-03-09 12:19     ` Eli Zaretskii
2023-03-09 13:07       ` João Távora
2023-03-09 15:54         ` Eli Zaretskii
2023-03-09 11:56   ` Eli Zaretskii
2023-03-09 12:10     ` Tassilo Horn
2023-03-09 13:12       ` João Távora
2023-03-10  7:44         ` Tassilo Horn
2023-03-09 12:19     ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mt4m2w23.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).