From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Unsafe local variable in eglot.el Date: Thu, 09 Mar 2023 10:00:52 +0200 Message-ID: <83mt4m2w23.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11097"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 09 09:01:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paBDk-0002hU-66 for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Mar 2023 09:01:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paBCo-00075N-4p; Thu, 09 Mar 2023 03:00:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paBCm-00074w-GA for emacs-devel@gnu.org; Thu, 09 Mar 2023 03:00:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paBCm-00037r-7k; Thu, 09 Mar 2023 03:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:To:From:Date:in-reply-to: references; bh=x7twwMvMuJicbdn+RLgjpHhisY26yxarhKQE/EAkEAg=; b=afRckuGcbA/YrM jh1YO2sw1KrOhSSSCTYJVSmqB1J7akEpXgzMclIxmtX6+JcuBVH75UX94bEXR+JfNT40cpJeFB4+r ZQS7dTgzpTMo3u5gWLP+0AKT6YlhB87mewLVfFmzUzt5KaJ4+NemRK7WLyGnLtpyDLVCmBaOvr1hh XsgLhYV4wknE9KpE4dCAe83daj4HvaOULJG4XQ9KVTceZEfVpomTLDBCFOzXcZL9IfZ1pOQapDDM6 l7TBVNm5ALz0CFIgnYgBEFk3rbi2etudpkkMq+yXy8CMZEyQpKClt4nlTWKw6K6Htb2dttBKOTGAa ArM4fRGHk/V6cruAA2mw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paBCl-0001q9-Ja; Thu, 09 Mar 2023 03:00:51 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304167 Archived-At: João, This recent change: commit 0a4b1c0102d4062d24e19340f863b9df25e07ab3 Author: Joao Távora AuthorDate: Wed Mar 1 13:24:07 2023 +0000 Commit: Joao Távora CommitDate: Wed Mar 1 13:27:06 2023 +0000 ; Eglot: improve bug-reference-url-format/bug-reference-url-regexp * lisp/progmodes/eglot.el (eglot--debbugs-or-github-bug-uri): New helper. causes trouble when visiting eglot.el. First, this pops up the "variable may not be safe" buffer about the variable bug-reference-url-format, even if I use Emacs 29, let alone if I use older Emacs versions. And second, if I say "y" to the "apply unsafe variable" prompt, then with the following jit-lock settings: (setq jit-lock-stealth-time 16) (setq jit-lock-stealth-nice 0.5) (setq jit-lock-stealth-verbose t) (setq jit-lock-defer-contextually t) (setq jit-lock-stealth-load 20) I get an error from jit-lock-stealth's timer: Error running timer ‘jit-lock-stealth-fontify’: (void-function eglot--debbugs-or-github-bug-uri) The only way of avoiding these two issues is to say "n" to the prompt asking whether to apply the variable, but that's not really a good workaround, is it? Can these problems be solved, please, preferably in a way that older Emacsen will also be happy (since Eglot is an ELPA package)?