unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: master 42596bd 2/6: Little improvements in rmail.el. Recognize encryped override headers.
Date: Wed, 12 May 2021 18:45:48 +0300	[thread overview]
Message-ID: <83lf8k2bwz.fsf@gnu.org> (raw)
In-Reply-To: <jwv1racj8a8.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 12 May 2021 11:14:47 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  rms@gnu.org,  emacs-devel@gnu.org
> Date: Wed, 12 May 2021 11:14:47 -0400
> 
> Eli Zaretskii [2021-05-12 16:12:46] wrote:
> > Drew might be a single person, but he tends to flood the Emacs mailing
> > lists with a lot of messages carrying this addition.  Rmail's
> > threading is based on comparing their Subject lines, and Rmail already
> > has quite a few heuristics whose purpose is to clean up the Subject
> > line to that end.  I see nothing wrong with adding one more
> > heuristics; the problem hits me as well.
> 
> But this shouldn't be embedded directly into the code.
> We should have instead a variable specifying those cases (so it can be
> extended/adjusted depending on the cases the users face).

It's an internal implementation detail that no user will ever want to
change, so I see no reason to have a separate variable.  We already
have several strings there hard coded into the function, and I see
nothing wrong with having one more.

If it turns out this addition comes in several variants that are not
expressible as a simple regexp, we will probably make a variable, as
we do with other similar additions.



  reply	other threads:[~2021-05-12 15:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210512030946.27770.7288@vcs0.savannah.gnu.org>
     [not found] ` <20210512030949.65CD421128@vcs0.savannah.gnu.org>
2021-05-12  8:16   ` master 47070ed 6/6: Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs Robert Pluim
2021-05-12 12:50     ` Eli Zaretskii
2021-05-13  4:53       ` Richard Stallman
2021-05-13  6:38         ` Eli Zaretskii
2021-05-14  5:23           ` Richard Stallman
2021-05-14  7:00             ` Eli Zaretskii
2021-05-14 13:45               ` Stefan Monnier
2021-05-14 14:49                 ` Andreas Schwab
2021-05-16  4:37               ` Richard Stallman
     [not found] ` <20210512030948.6448F21128@vcs0.savannah.gnu.org>
2021-05-12 12:17   ` master 42596bd 2/6: Little improvements in rmail.el. Recognize encryped override headers Lars Ingebrigtsen
2021-05-12 13:12     ` Eli Zaretskii
2021-05-12 13:16       ` Lars Ingebrigtsen
2021-05-12 13:20       ` Eli Zaretskii
2021-05-12 15:14       ` Stefan Monnier
2021-05-12 15:45         ` Eli Zaretskii [this message]
2021-05-12 15:47         ` Lars Ingebrigtsen
2021-05-12 15:59           ` Eli Zaretskii
2021-05-12 15:54         ` Robert Pluim
2021-05-12 14:03     ` Gregory Heytings
2021-05-12 14:17       ` Gregory Heytings
2021-05-13  4:52     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lf8k2bwz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).