From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 42596bd 2/6: Little improvements in rmail.el. Recognize encryped override headers. Date: Wed, 12 May 2021 18:45:48 +0300 Message-ID: <83lf8k2bwz.fsf@gnu.org> References: <20210512030946.27770.7288@vcs0.savannah.gnu.org> <20210512030948.6448F21128@vcs0.savannah.gnu.org> <87a6p0kuxi.fsf@gnus.org> <8335us3xkh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19566"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, rms@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 12 17:51:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgr8z-0004gs-1X for ged-emacs-devel@m.gmane-mx.org; Wed, 12 May 2021 17:51:29 +0200 Original-Received: from localhost ([::1]:35464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgr8y-0003Q0-4B for ged-emacs-devel@m.gmane-mx.org; Wed, 12 May 2021 11:51:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgr3y-0007e8-H2 for emacs-devel@gnu.org; Wed, 12 May 2021 11:46:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34164) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgr3w-0000yI-RP; Wed, 12 May 2021 11:46:17 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1133 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgr3b-0000tz-9z; Wed, 12 May 2021 11:45:57 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 12 May 2021 11:14:47 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269212 Archived-At: > From: Stefan Monnier > Cc: Lars Ingebrigtsen , rms@gnu.org, emacs-devel@gnu.org > Date: Wed, 12 May 2021 11:14:47 -0400 > > Eli Zaretskii [2021-05-12 16:12:46] wrote: > > Drew might be a single person, but he tends to flood the Emacs mailing > > lists with a lot of messages carrying this addition. Rmail's > > threading is based on comparing their Subject lines, and Rmail already > > has quite a few heuristics whose purpose is to clean up the Subject > > line to that end. I see nothing wrong with adding one more > > heuristics; the problem hits me as well. > > But this shouldn't be embedded directly into the code. > We should have instead a variable specifying those cases (so it can be > extended/adjusted depending on the cases the users face). It's an internal implementation detail that no user will ever want to change, so I see no reason to have a separate variable. We already have several strings there hard coded into the function, and I see nothing wrong with having one more. If it turns out this addition comes in several variants that are not expressible as a simple regexp, we will probably make a variable, as we do with other similar additions.