unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Changelog scripts
@ 2020-05-20 18:50 Vasilij Schneidermann
  2020-05-20 19:09 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Vasilij Schneidermann @ 2020-05-20 18:50 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Hello,

I've found that the gcc developers set up a set of client- and server-side
scripts for Git [1] which verify commits for correct changelog format usage and
generate changelog files from all commits.  IIRC there has been copious
discussion on the merits of the latter before with no clear conclusion, however
I believe that validating commits would be helpful, especially for new
contributors.  In case the gcc scripts are not considered good enough, perhaps
the vc-dwim tools [2] or some existing Emacs Lisp code [3] could do.

I've run into this particular hurdle numerous times and would prefer Git to
yell at me instead of the maintainer reviewing my patch :)

Vasilij

[1]: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545662.html
[2]: https://www.gnu.org/software/vc-dwim/
[3]: lisp/vc/add-log.el

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Changelog scripts
  2020-05-20 18:50 Changelog scripts Vasilij Schneidermann
@ 2020-05-20 19:09 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2020-05-20 19:09 UTC (permalink / raw)
  To: Vasilij Schneidermann; +Cc: emacs-devel

> Date: Wed, 20 May 2020 20:50:00 +0200
> From: Vasilij Schneidermann <emacs-devel@vasilij.de>
> 
> I've found that the gcc developers set up a set of client- and server-side
> scripts for Git [1] which verify commits for correct changelog format usage and
> generate changelog files from all commits.  IIRC there has been copious
> discussion on the merits of the latter before with no clear conclusion, however
> I believe that validating commits would be helpful, especially for new
> contributors.  In case the gcc scripts are not considered good enough, perhaps
> the vc-dwim tools [2] or some existing Emacs Lisp code [3] could do.

We produce ChangeLog files from Git logs for several years now.  (GCC,
by contrast, maintained actual ChangeLog files until very recently.)

As for checking the log format: it isn't that GCC scripts are "not
good enough".  They are GCC-specific, in the sense that they do
various things such as formatting the logs according to what the GCC
developers are used to, which is different from what we do.  They have
several rules that we explicitly don't endorse, and others (e.g.,
related to branches) that are not relevant for us.

Of course, if someone wants to work on a similar script for our
purposes, feel free.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-20 19:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 18:50 Changelog scripts Vasilij Schneidermann
2020-05-20 19:09 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).