unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs pretest 28.0.90 is out
Date: Thu, 09 Dec 2021 11:16:38 +0200	[thread overview]
Message-ID: <83k0geuoi1.fsf@gnu.org> (raw)
In-Reply-To: <8735n2cyui.fsf@yahoo.com> (message from Po Lu on Thu, 09 Dec 2021 10:10:29 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 Dec 2021 10:10:29 +0800
> 
>     sysdep.c:2321: undefined reference to `_openat'
>     ld: sysdep.o: in function `_emacs_open_noquit':
>     sysdep.c:2349: undefined reference to `_openat'
>     ld: sysdep.o: in function `_safe_strsignal':
>     sysdep.c:2639: undefined reference to `_sigdescr_np'
>     ld: fileio.o: in function `_Fcopy_file':
>     fileio.c:2298: undefined reference to `_copy_file_range'
>     ld: fileio.c:2390: undefined reference to `_futimens'
>     ld: fileio.o: in function `_Fset_file_modes':
>     fileio.c:3526: undefined reference to `_fchmodat'
>     ld: fileio.o: in function `_Fset_file_times':
>     fileio.c:3595: undefined reference to `_utimensat'
>     ld: callproc.o: in function `_emacs_spawn':
>     callproc.c:1612: undefined reference to `_unblock_child_signal'
>     ld: callproc.c:1615: undefined reference to `_child_setup_tty'
> 
> I would like to reimplement `openat' and `copy_file_range', and to stub
> the rest, but before I proceed I'd like to ask if there's already an
> implementation of openat and copy_file_range somewhere in DJGPP (or
> gnulib) that I overlooked.

There's at-func.c in lib/, which implements the *at functions.  But
msdos.c was emulating them on its own, see readlinkat, faccessat, and
other similar functions there.  Their code is quite boilerplate, so it
shouldn't be hard to add a couple more of them.  You can use the code
in w32.c as inspiration (but without the conversion of file names from
UTF-8).  That should take care of openat and fchmodat.

I wouldn't recommend implementing copy_file_range, unless you mean the
trivial implementation that returns an error indication, like the
Gnulib version does.

As for the rest, my recommendation is to implement futimens based on
DJGPP's setftime.  unblock_child_signal and child_setup_type should be
#ifdef'ed away for MSDOS.  As for sigdescr_np, try to compile Gnulib's
sigdescr_np.c, and if that doesn't work, it should be easy to write an
emulation using sys_siglist, which DJGPP does have.



  reply	other threads:[~2021-12-09  9:16 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 22:41 Emacs pretest 28.0.90 is out Stefan Kangas
2021-12-05  3:38 ` Po Lu
2021-12-05  8:00   ` Eli Zaretskii
2021-12-05 10:34     ` Po Lu
2021-12-05 10:59       ` Eli Zaretskii
2021-12-05 11:18         ` Po Lu
2021-12-05 11:24           ` Eli Zaretskii
2021-12-05 11:30             ` Po Lu
2021-12-05 13:48               ` Eli Zaretskii
2021-12-06  0:53                 ` Po Lu
2021-12-06 12:49                   ` Eli Zaretskii
2021-12-06 13:26                     ` Po Lu
2021-12-06 13:41                       ` Po Lu
2021-12-06 14:05                         ` Eli Zaretskii
2021-12-07  0:42                           ` Po Lu
2021-12-07  2:16                             ` Po Lu
2021-12-07 13:40                               ` Eli Zaretskii
2021-12-08  1:02                                 ` Po Lu
2021-12-08 12:37                                   ` Eli Zaretskii
2021-12-08 13:26                                     ` Po Lu
2021-12-08 13:36                                       ` Eli Zaretskii
2021-12-09  2:10                                         ` Po Lu
2021-12-09  9:16                                           ` Eli Zaretskii [this message]
2021-12-09 10:31                                             ` Po Lu
2021-12-09 10:41                                               ` Eli Zaretskii
2021-12-09 11:00                                                 ` Po Lu
2021-12-09 12:16                                                   ` Eli Zaretskii
2021-12-09 12:42                                                     ` Po Lu
2021-12-09 12:43                                                     ` Eli Zaretskii
2021-12-09 12:49                                                       ` Po Lu
2021-12-09 12:56                                                         ` Po Lu
2021-12-09 13:08                                                           ` Eli Zaretskii
2021-12-09 13:18                                                             ` Po Lu
2021-12-09 13:40                                                               ` Eli Zaretskii
2021-12-09 13:42                                                                 ` Eli Zaretskii
2021-12-09 13:50                                                                   ` Po Lu
2021-12-09 13:47                                                                 ` Po Lu
2021-12-09 14:07                                                                   ` Eli Zaretskii
2021-12-09 14:24                                                                     ` Eli Zaretskii
2021-12-09 14:33                                                                       ` Eli Zaretskii
2021-12-09 14:44                                                                         ` Eli Zaretskii
2021-12-10  0:23                                                                           ` Po Lu
2021-12-10  0:44                                                                             ` Po Lu
2021-12-10  8:36                                                                               ` Eli Zaretskii
2021-12-10  9:35                                                                                 ` Po Lu
2021-12-10 13:44                                                                                   ` Po Lu via Emacs development discussions.
2021-12-10 14:26                                                                                     ` Eli Zaretskii
2021-12-11  1:06                                                                                       ` Po Lu
2021-12-11  8:08                                                                                         ` Eli Zaretskii
2021-12-11  9:42                                                                                           ` Po Lu via Emacs development discussions.
2021-12-11 11:23                                                                                             ` Eli Zaretskii
2021-12-11 11:51                                                                                               ` Po Lu
2021-12-06 13:55                       ` Eli Zaretskii
2021-12-05  3:42 ` David O'Toole
2021-12-05  9:34   ` H. Dieter Wilhelm
2021-12-09  1:31 ` pretest installed (was: Emacs pretest 28.0.90 is out) andrés ramírez
2021-12-12  9:20 ` MingGW: Bug in TeX input-method?, was: Re: Emacs pretest 28.0.90 is out H. Dieter Wilhelm
2021-12-12  9:32   ` Eli Zaretskii
2021-12-12 15:48     ` H. Dieter Wilhelm
2021-12-12 16:03       ` Eli Zaretskii
2021-12-12 17:25         ` H. Dieter Wilhelm
2021-12-12 18:22           ` Eli Zaretskii
2021-12-12 19:20           ` Stefan Monnier
2021-12-12 21:44             ` TeX input method lacking subscript characters, was: Re: MingGW: Bug in TeX input-method? H. Dieter Wilhelm
2021-12-12 23:00               ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0geuoi1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).