From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs pretest 28.0.90 is out
Date: Sat, 11 Dec 2021 13:23:59 +0200 [thread overview]
Message-ID: <83fsqzqt9s.fsf@gnu.org> (raw)
In-Reply-To: <87r1aj32bc.fsf@yahoo.com> (message from Po Lu on Sat, 11 Dec 2021 17:42:31 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 11 Dec 2021 17:42:31 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > And in any case, even if you want not to go through a temporary file,
> > I'd prefer to edit the original recipe in sed1v2.inp instead of adding
> > a DOS-specific recipe, as the former is safer for changes on the
> > release branch.
>
> Thanks, I opted to implement this option, and it works well.
>
> I also implemented futimens (and based on that, utimensat), and fixed
> the rest of the issues you outlined above.
>
> If the following patch looks good to you, I will install it on
> emacs-28. Thanks.
A couple of minor gotchas below, and then you can install this.
> +int
> +fchmodat (int fd, const char *path, mode_t mode, int flags)
> +{
> + if (fd != AT_FDCWD)
> + {
> + if (strlen (dir_pathname) + strlen (path) + 1 >= MAXPATHLEN)
> + {
> + errno = ENAMETOOLONG;
> + return -1;
> + }
> + }
> +
> + return chmod (path, mode);
> +}
No support for AT_FDCWD here (by using dir_pathname)?
> +int
> +futimens (int fd, const struct timespec times[2])
> +{
> + struct tm *tm;
> + struct ftime ft;
> + time_t t;
> +
> + block_input ();
> + if (times[1].tv_sec == UTIME_NOW)
> + t = time (NULL);
> + else
> + t = times[1].tv_sec;
> +
> + tm = localtime (&t);
> + ft.ft_tsec = min (59, tm->tm_sec);
ft_sec is 0 to 29, in 2-sec units (as DOS has only 2-sec resolution in
file time stamps), so you need to scale it here.
> +int
> +utimensat (int dirfd, const char *pathname,
> + const struct timespec times[2], int flags)
> +{
> + int fd;
> + char fullname[MAXPATHLEN];
> +
> + if (dirfd != AT_FDCWD)
> + {
> + if (strlen (dir_pathname) + strlen (pathname) + 1 >= MAXPATHLEN)
> + {
> + errno = ENAMETOOLONG;
> + return -1;
> + }
> + sprintf (fullname, "%s/%s", dir_pathname, pathname);
> + pathname = fullname;
> + }
> +
> + /* Rely on a hack: dirfd in its current usage in Emacs is always
> + AT_FDCWD. */
This comment seems to be out of place, you need to move it higher up,
I believe.
> + fd = open (pathname, O_WRONLY);
> +
> + if (fd < 0)
> + return -1;
> +
> + return futimens (fd, times);
This leaks a file descriptor, since you open the file, but don't close
it.
Thanks.
next prev parent reply other threads:[~2021-12-11 11:23 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 22:41 Emacs pretest 28.0.90 is out Stefan Kangas
2021-12-05 3:38 ` Po Lu
2021-12-05 8:00 ` Eli Zaretskii
2021-12-05 10:34 ` Po Lu
2021-12-05 10:59 ` Eli Zaretskii
2021-12-05 11:18 ` Po Lu
2021-12-05 11:24 ` Eli Zaretskii
2021-12-05 11:30 ` Po Lu
2021-12-05 13:48 ` Eli Zaretskii
2021-12-06 0:53 ` Po Lu
2021-12-06 12:49 ` Eli Zaretskii
2021-12-06 13:26 ` Po Lu
2021-12-06 13:41 ` Po Lu
2021-12-06 14:05 ` Eli Zaretskii
2021-12-07 0:42 ` Po Lu
2021-12-07 2:16 ` Po Lu
2021-12-07 13:40 ` Eli Zaretskii
2021-12-08 1:02 ` Po Lu
2021-12-08 12:37 ` Eli Zaretskii
2021-12-08 13:26 ` Po Lu
2021-12-08 13:36 ` Eli Zaretskii
2021-12-09 2:10 ` Po Lu
2021-12-09 9:16 ` Eli Zaretskii
2021-12-09 10:31 ` Po Lu
2021-12-09 10:41 ` Eli Zaretskii
2021-12-09 11:00 ` Po Lu
2021-12-09 12:16 ` Eli Zaretskii
2021-12-09 12:42 ` Po Lu
2021-12-09 12:43 ` Eli Zaretskii
2021-12-09 12:49 ` Po Lu
2021-12-09 12:56 ` Po Lu
2021-12-09 13:08 ` Eli Zaretskii
2021-12-09 13:18 ` Po Lu
2021-12-09 13:40 ` Eli Zaretskii
2021-12-09 13:42 ` Eli Zaretskii
2021-12-09 13:50 ` Po Lu
2021-12-09 13:47 ` Po Lu
2021-12-09 14:07 ` Eli Zaretskii
2021-12-09 14:24 ` Eli Zaretskii
2021-12-09 14:33 ` Eli Zaretskii
2021-12-09 14:44 ` Eli Zaretskii
2021-12-10 0:23 ` Po Lu
2021-12-10 0:44 ` Po Lu
2021-12-10 8:36 ` Eli Zaretskii
2021-12-10 9:35 ` Po Lu
2021-12-10 13:44 ` Po Lu via Emacs development discussions.
2021-12-10 14:26 ` Eli Zaretskii
2021-12-11 1:06 ` Po Lu
2021-12-11 8:08 ` Eli Zaretskii
2021-12-11 9:42 ` Po Lu via Emacs development discussions.
2021-12-11 11:23 ` Eli Zaretskii [this message]
2021-12-11 11:51 ` Po Lu
2021-12-06 13:55 ` Eli Zaretskii
2021-12-05 3:42 ` David O'Toole
2021-12-05 9:34 ` H. Dieter Wilhelm
2021-12-09 1:31 ` pretest installed (was: Emacs pretest 28.0.90 is out) andrés ramírez
2021-12-12 9:20 ` MingGW: Bug in TeX input-method?, was: Re: Emacs pretest 28.0.90 is out H. Dieter Wilhelm
2021-12-12 9:32 ` Eli Zaretskii
2021-12-12 15:48 ` H. Dieter Wilhelm
2021-12-12 16:03 ` Eli Zaretskii
2021-12-12 17:25 ` H. Dieter Wilhelm
2021-12-12 18:22 ` Eli Zaretskii
2021-12-12 19:20 ` Stefan Monnier
2021-12-12 21:44 ` TeX input method lacking subscript characters, was: Re: MingGW: Bug in TeX input-method? H. Dieter Wilhelm
2021-12-12 23:00 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fsqzqt9s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).