From: Eli Zaretskii <eliz@gnu.org>
To: chenbin.sh@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] add 'string-distance' to calculate Levenshtein distance
Date: Sat, 28 Apr 2018 10:36:20 +0300 [thread overview]
Message-ID: <83in8bu6iz.fsf@gnu.org> (raw)
In-Reply-To: <83fu3pxbu9.fsf@gnu.org> (message from Eli Zaretskii on Sat, 21 Apr 2018 10:22:54 +0300)
> Date: Sat, 21 Apr 2018 10:22:54 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > From: chen bin <chenbin.sh@gmail.com>
> > Date: Fri, 20 Apr 2018 20:47:23 +1000
> > Cc: emacs-devel@gnu.org
> >
> > Attached is latest patch. It will use byte compare aglorithm if both
> > strings are not multi-byte strings.
>
> Thanks, let's give people a few days to comment.
No further comments, so I pushed your changes.
A few comments for your future contributions:
. Please include with the changes a commit log message, formatted as
described in CONTRIBUTE.
. We encourage to include changes for the relevant manuals with the
code changes; please try doing that in the future. If you do
include the relevant manual changes, mark the NEWS entry with
"+++" to indicate that.
. The tests should be in the file named after the file where the
relevant feature(s) is/are defined. If the code is in src/FOO.c,
the tests should be in test/src /FOO-tests.el; if the code is in
lisp/foo/BAR.el, the tests should be in test/lisp/foo/BAR-tests.el.
Thanks.
next prev parent reply other threads:[~2018-04-28 7:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 2:35 [PATCH] add 'string-distance' to calculate Levenshtein distance Chen Bin
2018-04-14 7:05 ` Eli Zaretskii
[not found] ` <87lgdq831h.fsf@gmail.com>
2018-04-14 13:24 ` Eli Zaretskii
2018-04-14 16:40 ` Chen Bin
2018-04-14 17:08 ` Eli Zaretskii
2018-04-15 7:15 ` Chen Bin
2018-04-15 14:47 ` Eli Zaretskii
[not found] ` <CAAE-R+-RDWvyrv+uqHszzh6VMH6An3disOw=PyPWaTnUTHDOCw@mail.gmail.com>
[not found] ` <83k1t72b2o.fsf@gnu.org>
2018-04-17 2:43 ` chen bin
2018-04-17 15:44 ` Eli Zaretskii
2018-04-18 7:11 ` chen bin
[not found] ` <CAAE-R+8s++_LRcQCLX60Z=TQeQHdtbM5X1k525bfNnnPSLDvRw@mail.gmail.com>
[not found] ` <83bmei36dw.fsf@gnu.org>
2018-04-17 12:31 ` chen bin
2018-04-19 8:05 ` Eli Zaretskii
2018-04-19 14:55 ` chen bin
2018-04-20 4:37 ` chen bin
2018-04-20 6:01 ` Thien-Thi Nguyen
2018-04-20 10:47 ` chen bin
2018-04-21 7:22 ` Eli Zaretskii
2018-04-21 20:47 ` Juri Linkov
2018-04-28 7:36 ` Eli Zaretskii [this message]
2018-05-06 9:53 ` chen bin
2018-04-15 18:53 ` Paul Eggert
2018-04-14 17:18 ` Nathan Moreau
2018-04-14 17:36 ` Paul Eggert
2018-04-15 18:17 ` Andreas Politz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83in8bu6iz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=chenbin.sh@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).