From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add 'string-distance' to calculate Levenshtein distance Date: Sat, 28 Apr 2018 10:36:20 +0300 Message-ID: <83in8bu6iz.fsf@gnu.org> References: <87vacuecrn.fsf@gmail.com> <83po3246ah.fsf@gnu.org> <87lgdq831h.fsf@gmail.com> <83muy553ae.fsf@gnu.org> <87o9ilhhcd.fsf@gmail.com> <83d0z14sws.fsf@gnu.org> <87o9il0wka.fsf@gmail.com> <83bmek4jdn.fsf@gnu.org> <83k1t72b2o.fsf@gnu.org> <83bmei36dw.fsf@gnu.org> <83wox3zkm7.fsf@gnu.org> <83fu3pxbu9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1524900883 19976 195.159.176.226 (28 Apr 2018 07:34:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Apr 2018 07:34:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: chenbin.sh@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 28 09:34:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCKNS-00054b-Mm for ged-emacs-devel@m.gmane.org; Sat, 28 Apr 2018 09:34:38 +0200 Original-Received: from localhost ([::1]:51194 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCKPX-0003ng-To for ged-emacs-devel@m.gmane.org; Sat, 28 Apr 2018 03:36:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCKPR-0003na-P8 for emacs-devel@gnu.org; Sat, 28 Apr 2018 03:36:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fCKPO-0005Jx-MX for emacs-devel@gnu.org; Sat, 28 Apr 2018 03:36:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCKPO-0005Jt-Io; Sat, 28 Apr 2018 03:36:38 -0400 Original-Received: from [176.228.60.248] (port=4957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fCKPN-0000N3-Vg; Sat, 28 Apr 2018 03:36:38 -0400 In-reply-to: <83fu3pxbu9.fsf@gnu.org> (message from Eli Zaretskii on Sat, 21 Apr 2018 10:22:54 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224928 Archived-At: > Date: Sat, 21 Apr 2018 10:22:54 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > From: chen bin > > Date: Fri, 20 Apr 2018 20:47:23 +1000 > > Cc: emacs-devel@gnu.org > > > > Attached is latest patch. It will use byte compare aglorithm if both > > strings are not multi-byte strings. > > Thanks, let's give people a few days to comment. No further comments, so I pushed your changes. A few comments for your future contributions: . Please include with the changes a commit log message, formatted as described in CONTRIBUTE. . We encourage to include changes for the relevant manuals with the code changes; please try doing that in the future. If you do include the relevant manual changes, mark the NEWS entry with "+++" to indicate that. . The tests should be in the file named after the file where the relevant feature(s) is/are defined. If the code is in src/FOO.c, the tests should be in test/src /FOO-tests.el; if the code is in lisp/foo/BAR.el, the tests should be in test/lisp/foo/BAR-tests.el. Thanks.