From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-case handler (Bug#24618)
Date: Fri, 07 Sep 2018 09:51:50 +0300 [thread overview]
Message-ID: <83in3hvlyx.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV-_P6vWQ5SrJxE9cfoF6-h+DGPNJMKjr+g+1SMSWbcuD1A@mail.gmail.com> (message from Noam Postavsky on Thu, 6 Sep 2018 21:01:31 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Thu, 6 Sep 2018 21:01:31 -0400
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> DEFUN ("condition-case", Fcondition_case, Scondition_case, 2, UNEVALLED, 0,
> - doc: /* Regain control when an error is signaled.
> -Executes BODYFORM and returns its value if no error happens.
> + doc: /* Regain control when a condition is signaled.
> +Executes BODYFORM and returns its value if nothing is signaled.
> Each element of HANDLERS looks like (CONDITION-NAME BODY...)
> where the BODY is made of Lisp expressions.
>
> -A handler is applicable to an error if CONDITION-NAME is one of the
> -error's condition names. A CONDITION-NAME of t applies to any error
> -symbol. If an error happens, the first applicable handler is run.
> +A handler is applicable to a condition if CONDITION-NAME is one of the
> +condition's names. A CONDITION-NAME of t applies to any condition
^^^^^^^^^^^
This should be "conditions'", I think, as it's plural.
> +name. If a condition is signaled, the first applicable handler is run.
I find "condition is signaled" slightly confusing, though. Why not
use "signal" instead? A "signal" is not necessarily an error, so I
think the root cause for this change will be taken care of. WDYT?
next prev parent reply other threads:[~2018-09-07 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180904230314.12505.44942@vcs0.savannah.gnu.org>
[not found] ` <20180904230315.6EB44209DC@vcs0.savannah.gnu.org>
2018-09-05 2:46 ` [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-case handler (Bug#24618) Stefan Monnier
2018-09-05 14:38 ` Noam Postavsky
2018-09-05 15:31 ` Stefan Monnier
2018-09-07 1:01 ` Noam Postavsky
2018-09-07 1:08 ` Stefan Monnier
2018-09-07 1:10 ` Davis Herring
2018-09-08 2:16 ` Noam Postavsky
2018-09-17 0:40 ` Noam Postavsky
2018-09-07 6:51 ` Eli Zaretskii [this message]
2018-09-07 7:00 ` Davis Herring
2018-09-07 7:24 ` Eli Zaretskii
[not found] ` <<83ftylvkgw.fsf@gnu.org>
2018-09-07 15:19 ` Drew Adams
[not found] ` <<83in3hvlyx.fsf@gnu.org>
2018-09-07 15:17 ` Drew Adams
2018-09-05 15:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83in3hvlyx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).