From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-case handler (Bug#24618) Date: Fri, 07 Sep 2018 09:51:50 +0300 Message-ID: <83in3hvlyx.fsf@gnu.org> References: <20180904230314.12505.44942@vcs0.savannah.gnu.org> <20180904230315.6EB44209DC@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536302997 9550 195.159.176.226 (7 Sep 2018 06:49:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2018 06:49:57 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 08:49:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyAaW-0002NL-GM for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2018 08:49:52 +0200 Original-Received: from localhost ([::1]:36967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyAcc-0007hz-Rs for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2018 02:52:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyAcU-0007hq-J8 for emacs-devel@gnu.org; Fri, 07 Sep 2018 02:51:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyAcP-0000p6-KP for emacs-devel@gnu.org; Fri, 07 Sep 2018 02:51:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyAcP-0000oz-GS; Fri, 07 Sep 2018 02:51:49 -0400 Original-Received: from [176.228.60.248] (port=1571 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fyAcP-0006W9-4h; Fri, 07 Sep 2018 02:51:49 -0400 In-reply-to: (message from Noam Postavsky on Thu, 6 Sep 2018 21:01:31 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229372 Archived-At: > From: Noam Postavsky > Date: Thu, 6 Sep 2018 21:01:31 -0400 > Cc: Emacs developers > > DEFUN ("condition-case", Fcondition_case, Scondition_case, 2, UNEVALLED, 0, > - doc: /* Regain control when an error is signaled. > -Executes BODYFORM and returns its value if no error happens. > + doc: /* Regain control when a condition is signaled. > +Executes BODYFORM and returns its value if nothing is signaled. > Each element of HANDLERS looks like (CONDITION-NAME BODY...) > where the BODY is made of Lisp expressions. > > -A handler is applicable to an error if CONDITION-NAME is one of the > -error's condition names. A CONDITION-NAME of t applies to any error > -symbol. If an error happens, the first applicable handler is run. > +A handler is applicable to a condition if CONDITION-NAME is one of the > +condition's names. A CONDITION-NAME of t applies to any condition ^^^^^^^^^^^ This should be "conditions'", I think, as it's plural. > +name. If a condition is signaled, the first applicable handler is run. I find "condition is signaled" slightly confusing, though. Why not use "signal" instead? A "signal" is not necessarily an error, so I think the root cause for this change will be taken care of. WDYT?