From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: joaotavora@gmail.com, emacs-devel@gnu.org
Subject: Re: Fixing post-self-insert-hook.
Date: Sat, 18 Sep 2021 08:50:26 +0300 [thread overview]
Message-ID: <83ilyy77q5.fsf@gnu.org> (raw)
In-Reply-To: <YUTud0tDubg7MRs6@ACM> (message from Alan Mackenzie on Fri, 17 Sep 2021 19:37:27 +0000)
> Date: Fri, 17 Sep 2021 19:37:27 +0000
> From: Alan Mackenzie <acm@muc.de>
> Cc: João Távora <joaotavora@gmail.com>
>
> Given that it is now (at least politically) impossible to ban buffer
> changing post-self-insert-hook functions, I propose to change the time at
> which the hook gets called.
>
> Instead of getting called straight after the self-insert-command, it
> should be called at the end of the command which called
> self-insert-command. Just before post-command-hook, perhaps. Yes there
> are details to be worked out.
>
> This will make no difference to the usual self-insert-command call. It
> will, however, restore the certainty of processing to Lisp code such as
> c-electric-brace without having to resort to ugly workarounds.
If CC Mode has problem with these hooks, it could bind them to nil
around the call to self-insert-command, couldn't it? That'd be much
better than making any globally-visible change in behavior, for which
we cannot possibly know the unintended consequences.
In any case, please let's not make this change before the emacs-28
branch is cut, as it can potentially disrupt many places.
next prev parent reply other threads:[~2021-09-18 5:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 19:37 Fixing post-self-insert-hook Alan Mackenzie
2021-09-17 20:04 ` Stefan Monnier
2021-09-17 20:53 ` Alan Mackenzie
2021-09-17 21:45 ` João Távora
2021-09-18 6:08 ` tomas
2021-09-18 8:44 ` João Távora
2021-09-18 14:15 ` Stefan Monnier
2021-09-18 15:56 ` Alan Mackenzie
2021-09-18 18:03 ` Stefan Monnier
[not found] ` <CALDnm52z_8HyqdC92nrMgzOMOOq48h2MQ4pjbROBOsdm5N_cJg@mail.gmail.com>
2021-09-18 22:55 ` João Távora
2021-09-19 12:14 ` Alan Mackenzie
2021-09-19 12:36 ` João Távora
2021-09-19 12:59 ` Stefan Monnier
2021-09-19 14:57 ` Alan Mackenzie
2021-09-19 20:20 ` Stefan Monnier
2021-09-17 20:15 ` João Távora
2021-09-17 20:35 ` Alan Mackenzie
2021-09-17 20:48 ` João Távora
2021-09-18 5:59 ` Eli Zaretskii
2021-09-18 9:41 ` Alan Mackenzie
2021-09-18 5:50 ` Eli Zaretskii [this message]
2021-09-18 9:57 ` Alan Mackenzie
2021-09-18 11:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilyy77q5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).