From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fixing post-self-insert-hook. Date: Sat, 18 Sep 2021 08:50:26 +0300 Message-ID: <83ilyy77q5.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29830"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 18 07:51:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRTG8-0007X2-J4 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Sep 2021 07:51:32 +0200 Original-Received: from localhost ([::1]:41394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRTG7-0007YW-Bl for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Sep 2021 01:51:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRTFM-0006nD-Lb for emacs-devel@gnu.org; Sat, 18 Sep 2021 01:50:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41258) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRTFL-0004R5-5y; Sat, 18 Sep 2021 01:50:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3264 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRTFJ-0002Jj-VG; Sat, 18 Sep 2021 01:50:42 -0400 In-Reply-To: (message from Alan Mackenzie on Fri, 17 Sep 2021 19:37:27 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274956 Archived-At: > Date: Fri, 17 Sep 2021 19:37:27 +0000 > From: Alan Mackenzie > Cc: João Távora > > Given that it is now (at least politically) impossible to ban buffer > changing post-self-insert-hook functions, I propose to change the time at > which the hook gets called. > > Instead of getting called straight after the self-insert-command, it > should be called at the end of the command which called > self-insert-command. Just before post-command-hook, perhaps. Yes there > are details to be worked out. > > This will make no difference to the usual self-insert-command call. It > will, however, restore the certainty of processing to Lisp code such as > c-electric-brace without having to resort to ugly workarounds. If CC Mode has problem with these hooks, it could bind them to nil around the call to self-insert-command, couldn't it? That'd be much better than making any globally-visible change in behavior, for which we cannot possibly know the unintended consequences. In any case, please let's not make this change before the emacs-28 branch is cut, as it can potentially disrupt many places.