* Re: master 99c276b 2/2: Revert "Preload paren.el"
@ 2021-11-30 18:02 Eli Zaretskii
2021-11-30 18:17 ` Andrea Corallo
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-11-30 18:02 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
> branch: master
> commit 99c276b3c0aee5599c1d281c1e9fe223810784ca
> Author: Andrea Corallo <akrl@sdf.org>
> Commit: Andrea Corallo <akrl@sdf.org>
>
> Revert "Preload paren.el"
>
> Reverting as the previous commit make this fix not anymore necessary.
Andrea, I don't understand this commit. We preload paren.el because
we now turn on show-paren-mode by default. After this commit, I get
an error message in this scenario:
emacs -Q
M-: (foo)
As soon as I type the right parenthesis, Emacs complains:
blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode
Your fix perhaps prevented the need for natively-compiling the
prerequisites of paren.el, but we should still preload it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 99c276b 2/2: Revert "Preload paren.el"
2021-11-30 18:02 master 99c276b 2/2: Revert "Preload paren.el" Eli Zaretskii
@ 2021-11-30 18:17 ` Andrea Corallo
2021-11-30 18:36 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Corallo @ 2021-11-30 18:17 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> branch: master
>> commit 99c276b3c0aee5599c1d281c1e9fe223810784ca
>> Author: Andrea Corallo <akrl@sdf.org>
>> Commit: Andrea Corallo <akrl@sdf.org>
>>
>> Revert "Preload paren.el"
>>
>> Reverting as the previous commit make this fix not anymore necessary.
>
> Andrea, I don't understand this commit. We preload paren.el because
> we now turn on show-paren-mode by default. After this commit, I get
> an error message in this scenario:
>
> emacs -Q
> M-: (foo)
>
> As soon as I type the right parenthesis, Emacs complains:
>
> blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode
>
> Your fix perhaps prevented the need for natively-compiling the
> prerequisites of paren.el, but we should still preload it.
Sincere apologies for the breakage, I erroneously thought the reverted
commit was only about the circular dependency issue we discussed
sometime ago.
Should be fixed by a7dfb2acfc
Best Regards
Andrea
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 99c276b 2/2: Revert "Preload paren.el"
2021-11-30 18:17 ` Andrea Corallo
@ 2021-11-30 18:36 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-11-30 18:36 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Tue, 30 Nov 2021 18:17:46 +0000
>
> > emacs -Q
> > M-: (foo)
> >
> > As soon as I type the right parenthesis, Emacs complains:
> >
> > blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode
> >
> > Your fix perhaps prevented the need for natively-compiling the
> > prerequisites of paren.el, but we should still preload it.
>
> Sincere apologies for the breakage, I erroneously thought the reverted
> commit was only about the circular dependency issue we discussed
> sometime ago.
>
> Should be fixed by a7dfb2acfc
Thanks, it's indeed fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-30 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 18:02 master 99c276b 2/2: Revert "Preload paren.el" Eli Zaretskii
2021-11-30 18:17 ` Andrea Corallo
2021-11-30 18:36 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).