unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Stipples and scroll optimizations
Date: Sun, 08 May 2022 10:40:26 +0300	[thread overview]
Message-ID: <83h760wjyt.fsf@gnu.org> (raw)
In-Reply-To: <875ymg5vgm.fsf@yahoo.com> (message from Po Lu on Sun, 08 May 2022 15:34:17 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 08 May 2022 15:34:17 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > If using scrolling_window in this case causes incorrect display, then
> > scrolling_window should be disabled.  But how would you know, in
> > update_window or its subroutines, that this is the case?
> 
> We could make x_draw_glyph_string (and its counterparts) set a flag
> inside the glyph row if a stipple is encountered, and then test that
> inside scrolling_window.

I think doing this is x_draw_glyph_string is too late, because that is
called after the test for applicability of scrolling_window was
already done, no?

Is the fact that some of the glyphs in a glyph-row use stipple easily
detectable by scanning the row's glyphs?  If so, update_window could
do that, just before it calls scrolling_window, and refrain from doing
so.

Alternatively, we could add a flag to the glyph_row structure, which
will be set the first time we see a face with stipple while producing
glyphs for the row, and then update_window could test that flag.



  reply	other threads:[~2022-05-08  7:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a6bs5w05.fsf.ref@yahoo.com>
2022-05-08  7:22 ` Stipples and scroll optimizations Po Lu
2022-05-08  7:30   ` Eli Zaretskii
2022-05-08  7:34     ` Po Lu
2022-05-08  7:40       ` Eli Zaretskii [this message]
2022-05-08  7:58         ` Po Lu
2022-05-08  9:06           ` Eli Zaretskii
2022-05-08  9:20             ` Po Lu
2022-05-08 10:46               ` Eli Zaretskii
2022-05-08 10:59                 ` Po Lu
2022-05-08 11:29                   ` Eli Zaretskii
2022-05-08 11:46                     ` Po Lu
2022-05-08 11:07                 ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h760wjyt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).