unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Stipples and scroll optimizations
Date: Sun, 08 May 2022 14:29:37 +0300	[thread overview]
Message-ID: <835ymgw9cu.fsf@gnu.org> (raw)
In-Reply-To: <87o80847dj.fsf@yahoo.com> (message from Po Lu on Sun, 08 May 2022 18:59:52 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 08 May 2022 18:59:52 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > But that can be different (even VERY different) from what _should_ be
> > on the glass.  We cannot rely on the current matrix for making such
> > decisions.
> 
> Yes, but the problem here is that we cannot copy what already _is_ on
> the glass if there is a stipple.  So the contents of the desired matrix
> are irrelevant for our purposes.

Not necessarily true.  update_window does this:

      /* Try reusing part of the display by copying.  */
      if (row < end && !desired_matrix->no_scrolling_p)  <<<<<<<<<<<<<
	{
	  int rc = scrolling_window (w, (tab_line_row != NULL ? 1 : 0)
				     + (header_line_row != NULL ? 1 : 0));

If the desired matrix is irrelevant, why do we test the no_scrolling_p
flag on that matrix?

Anyway, feel free to do it your way, but I'd be very weary of using
flags from the current matrix if a safer method exists.



  reply	other threads:[~2022-05-08 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a6bs5w05.fsf.ref@yahoo.com>
2022-05-08  7:22 ` Stipples and scroll optimizations Po Lu
2022-05-08  7:30   ` Eli Zaretskii
2022-05-08  7:34     ` Po Lu
2022-05-08  7:40       ` Eli Zaretskii
2022-05-08  7:58         ` Po Lu
2022-05-08  9:06           ` Eli Zaretskii
2022-05-08  9:20             ` Po Lu
2022-05-08 10:46               ` Eli Zaretskii
2022-05-08 10:59                 ` Po Lu
2022-05-08 11:29                   ` Eli Zaretskii [this message]
2022-05-08 11:46                     ` Po Lu
2022-05-08 11:07                 ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835ymgw9cu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).