* Re: [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes
[not found] ` <20180616101226.5451B2043E@vcs0.savannah.gnu.org>
@ 2018-06-16 14:34 ` Daniel Colascione
2018-06-16 15:08 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Colascione @ 2018-06-16 14:34 UTC (permalink / raw)
To: emacs-devel, Eli Zaretskii
On 06/16/2018 03:12 AM, Eli Zaretskii wrote:
> branch: master
> commit 0a6a2fb1d0b02a5ac442cf6b344e35696aac7eb7
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Improve documentation of several recent changes
face-filters-always-match is deliberately not mentioned in the elisp
manual. It's for face-remap.el's use only. Please remove the additional
text about it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes
2018-06-16 14:34 ` [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes Daniel Colascione
@ 2018-06-16 15:08 ` Eli Zaretskii
2018-06-16 15:21 ` Daniel Colascione
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-06-16 15:08 UTC (permalink / raw)
To: Daniel Colascione; +Cc: emacs-devel
> From: Daniel Colascione <dancol@dancol.org>
> Date: Sat, 16 Jun 2018 07:34:13 -0700
>
> On 06/16/2018 03:12 AM, Eli Zaretskii wrote:
> > branch: master
> > commit 0a6a2fb1d0b02a5ac442cf6b344e35696aac7eb7
> > Author: Eli Zaretskii <eliz@gnu.org>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> >
> > Improve documentation of several recent changes
>
> face-filters-always-match is deliberately not mentioned in the elisp
> manual. It's for face-remap.el's use only. Please remove the additional
> text about it.
I'll take it as a THANK YOU.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes
2018-06-16 15:08 ` Eli Zaretskii
@ 2018-06-16 15:21 ` Daniel Colascione
2018-06-16 15:58 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Colascione @ 2018-06-16 15:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Daniel Colascione, emacs-devel
>> From: Daniel Colascione <dancol@dancol.org>
>> Date: Sat, 16 Jun 2018 07:34:13 -0700
>>
>> On 06/16/2018 03:12 AM, Eli Zaretskii wrote:
>> > branch: master
>> > commit 0a6a2fb1d0b02a5ac442cf6b344e35696aac7eb7
>> > Author: Eli Zaretskii <eliz@gnu.org>
>> > Commit: Eli Zaretskii <eliz@gnu.org>
>> >
>> > Improve documentation of several recent changes
>>
>> face-filters-always-match is deliberately not mentioned in the elisp
>> manual. It's for face-remap.el's use only. Please remove the additional
>> text about it.
>
> I'll take it as a THANK YOU
Well, that too. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes
2018-06-16 15:21 ` Daniel Colascione
@ 2018-06-16 15:58 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2018-06-16 15:58 UTC (permalink / raw)
To: Daniel Colascione; +Cc: emacs-devel
> Date: Sat, 16 Jun 2018 08:21:04 -0700
> From: "Daniel Colascione" <dancol@dancol.org>
> Cc: "Daniel Colascione" <dancol@dancol.org>,
> emacs-devel@gnu.org
>
> >> face-filters-always-match is deliberately not mentioned in the elisp
> >> manual. It's for face-remap.el's use only. Please remove the additional
> >> text about it.
> >
> > I'll take it as a THANK YOU
>
> Well, that too. :-)
You are welcome.
As for documentation of face-filters-always-match: if we want it to be
an internal variable, let's name it as such, and let's say in the doc
string something like "Internal use only." Then removing it from the
manual will be a logical step.
See, that's why documenting features by those who write the code is
preferable: just by looking at the variable's name, doc string, and
uses (or lack thereof), it was hard for me to say what was the
original intent.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-16 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180616101224.6099.14566@vcs0.savannah.gnu.org>
[not found] ` <20180616101226.5451B2043E@vcs0.savannah.gnu.org>
2018-06-16 14:34 ` [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes Daniel Colascione
2018-06-16 15:08 ` Eli Zaretskii
2018-06-16 15:21 ` Daniel Colascione
2018-06-16 15:58 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).