Falling to build

Falling to build

[John]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

This morning all OK in building on openSuSe x86_64 until this happens

  CC       xfns.o
xfns.c: In function ‘Fx_display_monitor_attributes_list’:
xfns.c:5072:30: warning: implicit declaration of function ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? [-Wimplicit-function-declaration]
  if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r))
                              ^~~~~~~~~~~~~~~~~~
                              x_set_undecorated
xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ [-Wnested-externs]
make -C ../admin/charsets all
make[2]: Entering directory '/home/jpff/GNU/emacs/admin/charsets'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/jpff/GNU/emacs/admin/charsets'
make -C ../admin/unidata charscript.el
make[2]: Entering directory '/home/jpff/GNU/emacs/admin/unidata'
make[2]: Nothing to be done for 'charscript.el'.
make[2]: Leaving directory '/home/jpff/GNU/emacs/admin/unidata'
  CCLD     temacs
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: xfns.o: in function `Fx_display_monitor_attributes_list':
/home/jpff/GNU/emacs/src/xfns.c:5072: undefined reference to `x_get_net_workarea'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:651: temacs] Error 1

Should I try a make bootstrap or what?
==John ffitch

Falling to build

[John]

PS This is on master

Re: Falling to build

[Eli Zaretskii]

> Date: Wed,  1 Jan 2020 16:34:05 +0000
> From: John <jpff@codemist.co.uk>
> 
> This morning all OK in building on openSuSe x86_64 until this happens
> 
>   CC       xfns.o
> xfns.c: In function ‘Fx_display_monitor_attributes_list’:
> xfns.c:5072:30: warning: implicit declaration of function ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? [-Wimplicit-function-declaration]
>   if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r))
>                               ^~~~~~~~~~~~~~~~~~
>                               x_set_undecorated
> xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ [-Wnested-externs]

Does the patch below fix this?

diff --git a/src/xfns.c b/src/xfns.c
index b94666d..d0d5d39 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under,
     return Qnil;
 }
 
-#ifndef USE_GTK
+#if !defined USE_GTK || !defined HAVE_GTK3
 
 /* Store the geometry of the workarea on display DPYINFO into *RECT.
    Return false if and only if the workarea information cannot be

Re: Falling to build

[john]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

Yes; only oddity i saw was a message abaout an agresive macro -- but it 
went past too quickly fr me to capture te details.

Anyway no errors

==John ff

On Wed, 1 Jan 2020, Eli Zaretskii wrote:

>> Date: Wed,  1 Jan 2020 16:34:05 +0000
>> From: John <jpff@codemist.co.uk>
>>
>> This morning all OK in building on openSuSe x86_64 until this happens
>>
>>   CC       xfns.o
>> xfns.c: In function ‘Fx_display_monitor_attributes_list’:
>> xfns.c:5072:30: warning: implicit declaration of function ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? [-Wimplicit-function-declaration]
>>   if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r))
>>                               ^~~~~~~~~~~~~~~~~~
>>                               x_set_undecorated
>> xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ [-Wnested-externs]
>
> Does the patch below fix this?
>
> diff --git a/src/xfns.c b/src/xfns.c
> index b94666d..d0d5d39 100644
> --- a/src/xfns.c
> +++ b/src/xfns.c
> @@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under,
>     return Qnil;
> }
>
> -#ifndef USE_GTK
> +#if !defined USE_GTK || !defined HAVE_GTK3
>
> /* Store the geometry of the workarea on display DPYINFO into *RECT.
>    Return false if and only if the workarea information cannot be
>

Re: Falling to build

[Eli Zaretskii]

> Date: Wed, 1 Jan 2020 17:38:04 +0000 (GMT)
> From: john <jpff@codemist.co.uk>
> Cc: emacs-devel@gnu.org
> 
> Yes

Thanks, I installed that change.

> only oddity i saw was a message abaout an agresive macro -- but it
> went past too quickly fr me to capture te details.

That's a known issue, to be fixed shortly.

Re: Falling to build

[Sven Joachim]

On 2020-01-01 19:56 +0200, Eli Zaretskii wrote:

>> Date: Wed, 1 Jan 2020 17:38:04 +0000 (GMT)
>> From: john <jpff@codemist.co.uk>
>> Cc: emacs-devel@gnu.org
>>
>> Yes
>
> Thanks, I installed that change.

You did install it on master, but the problem still persists on the
emacs-27 branch.

Cheers,
       Sven

Re: Falling to build

[Eli Zaretskii]

> From: Sven Joachim <svenjoac@gmx.de>
> Cc: john <jpff@codemist.co.uk>,  emacs-devel@gnu.org
> Date: Wed, 01 Jan 2020 20:05:07 +0100
> 
> On 2020-01-01 19:56 +0200, Eli Zaretskii wrote:
> 
> >> Date: Wed, 1 Jan 2020 17:38:04 +0000 (GMT)
> >> From: john <jpff@codemist.co.uk>
> >> Cc: emacs-devel@gnu.org
> >>
> >> Yes
> >
> > Thanks, I installed that change.
> 
> You did install it on master, but the problem still persists on the
> emacs-27 branch.

Sorry, no one told me the change originated from the branch.  The
report was about master.

Should be fixed now.