unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 3555657: Remove unused argument from set_frame_menubar (Bug#45759)
       [not found] ` <20210130145955.BA0EC20E57@vcs0.savannah.gnu.org>
@ 2021-01-30 18:32   ` Michael Albinus
  2021-01-30 19:14     ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2021-01-30 18:32 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Kangas

stefankangas@gmail.com (Stefan Kangas) writes:

Hi Stefan,

> branch: master
> commit 3555657585bb2c1809fa6abff7f565a8c7f226eb
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
>     Remove unused argument from set_frame_menubar (Bug#45759)
>
>     * src/w32menu.c (set_frame_menubar):
>     * src/xmenu.c (set_frame_menubar): Remove unused argument.
>     All callers updated.
> ---
>  src/frame.h   |  2 +-
>  src/w32fns.c  |  2 +-
>  src/w32menu.c | 10 ++++------
>  src/xdisp.c   |  2 +-
>  src/xmenu.c   | 14 ++++++--------
>  5 files changed, 13 insertions(+), 17 deletions(-)

This triggers an error on emba.gnu.org for the ns build, see
<https://emba.gnu.org/emacs/emacs/-/jobs/11666/raw>. You must run

# ./configure --without-makeinfo --with-ns --no-create --no-recursion

Best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master 3555657: Remove unused argument from set_frame_menubar (Bug#45759)
  2021-01-30 18:32   ` master 3555657: Remove unused argument from set_frame_menubar (Bug#45759) Michael Albinus
@ 2021-01-30 19:14     ` Eli Zaretskii
  2021-01-31  0:29       ` Stefan Kangas
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-01-30 19:14 UTC (permalink / raw)
  To: Michael Albinus; +Cc: stefan, emacs-devel

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sat, 30 Jan 2021 19:32:17 +0100
> Cc: Stefan Kangas <stefan@marxist.se>
> 
> stefankangas@gmail.com (Stefan Kangas) writes:
> 
> Hi Stefan,
> 
> > branch: master
> > commit 3555657585bb2c1809fa6abff7f565a8c7f226eb
> > Author: Stefan Kangas <stefan@marxist.se>
> > Commit: Stefan Kangas <stefan@marxist.se>
> >
> >     Remove unused argument from set_frame_menubar (Bug#45759)
> >
> >     * src/w32menu.c (set_frame_menubar):
> >     * src/xmenu.c (set_frame_menubar): Remove unused argument.
> >     All callers updated.
> > ---
> >  src/frame.h   |  2 +-
> >  src/w32fns.c  |  2 +-
> >  src/w32menu.c | 10 ++++------
> >  src/xdisp.c   |  2 +-
> >  src/xmenu.c   | 14 ++++++--------
> >  5 files changed, 13 insertions(+), 17 deletions(-)
> 
> This triggers an error on emba.gnu.org for the ns build, see
> <https://emba.gnu.org/emacs/emacs/-/jobs/11666/raw>.

Thanks, I tried to fix that.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master 3555657: Remove unused argument from set_frame_menubar (Bug#45759)
  2021-01-30 19:14     ` Eli Zaretskii
@ 2021-01-31  0:29       ` Stefan Kangas
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2021-01-31  0:29 UTC (permalink / raw)
  To: Eli Zaretskii, Michael Albinus; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, I tried to fix that.

Thanks for the quick fix.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-31  0:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210130145954.4407.29803@vcs0.savannah.gnu.org>
     [not found] ` <20210130145955.BA0EC20E57@vcs0.savannah.gnu.org>
2021-01-30 18:32   ` master 3555657: Remove unused argument from set_frame_menubar (Bug#45759) Michael Albinus
2021-01-30 19:14     ` Eli Zaretskii
2021-01-31  0:29       ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).