From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master b02c9bc: Improve documentation of new Xref options
Date: Thu, 09 Sep 2021 09:26:46 +0300 [thread overview]
Message-ID: <83ee9yl0wp.fsf@gnu.org> (raw)
In-Reply-To: <23668bf1-4e51-b3ba-a8f6-6fe45f4639bc@yandex.ru> (message from Dmitry Gutov on Thu, 9 Sep 2021 04:22:48 +0300)
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 9 Sep 2021 04:22:48 +0300
>
> >> (cl-defmethod xref-backend-apropos ((_backend (eql 'etags)) pattern)
> >> - (etags--xref-find-definitions (xref-apropos-regexp pattern) t))
> >> + (let ((regexp (xref-apropos-regexp pattern)))
> >> + (nconc
> >> + (etags--xref-find-definitions regexp t)
> >> + (etags--xref-apropos-additional regexp))))
> >
> > I'm not sure I understand why is this specific to the etags backend.
> > The spec seems to be more general, and xref-find-apropos is not
> > specific to etags, right?
>
> If as you say above it is for feature parity with 'M-x tags-apropos',
> then the previously sent patch should be enough.
If you think it's enough, please go ahead and install it.
Thanks.
next prev parent reply other threads:[~2021-09-09 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210907130400.31609.90502@vcs0.savannah.gnu.org>
[not found] ` <20210907130401.D074320A10@vcs0.savannah.gnu.org>
2021-09-07 15:21 ` master b02c9bc: Improve documentation of new Xref options Dmitry Gutov
2021-09-07 15:45 ` Eli Zaretskii
2021-09-07 16:06 ` Dmitry Gutov
2021-09-07 16:23 ` Eli Zaretskii
2021-09-08 0:24 ` Dmitry Gutov
2021-09-08 6:18 ` Eli Zaretskii
2021-09-09 1:22 ` Dmitry Gutov
2021-09-09 6:26 ` Eli Zaretskii [this message]
2021-09-10 0:18 ` Dmitry Gutov
2021-09-10 12:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ee9yl0wp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).