From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b02c9bc: Improve documentation of new Xref options Date: Thu, 09 Sep 2021 09:26:46 +0300 Message-ID: <83ee9yl0wp.fsf@gnu.org> References: <20210907130400.31609.90502@vcs0.savannah.gnu.org> <20210907130401.D074320A10@vcs0.savannah.gnu.org> <83a6kopeye.fsf@gnu.org> <8335qgpd64.fsf@gnu.org> <9aef615d-039a-0c9f-fda7-f3fb11db9d47@yandex.ru> <83lf47oajr.fsf@gnu.org> <23668bf1-4e51-b3ba-a8f6-6fe45f4639bc@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30703"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 09 08:27:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mODX3-0007rN-5j for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Sep 2021 08:27:33 +0200 Original-Received: from localhost ([::1]:49734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mODX1-0000xy-SR for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Sep 2021 02:27:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mODW5-0008GA-Ua for emacs-devel@gnu.org; Thu, 09 Sep 2021 02:26:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48702) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mODW5-00061a-G9; Thu, 09 Sep 2021 02:26:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mODW5-0006nd-32; Thu, 09 Sep 2021 02:26:33 -0400 In-Reply-To: <23668bf1-4e51-b3ba-a8f6-6fe45f4639bc@yandex.ru> (message from Dmitry Gutov on Thu, 9 Sep 2021 04:22:48 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274426 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Thu, 9 Sep 2021 04:22:48 +0300 > > >> (cl-defmethod xref-backend-apropos ((_backend (eql 'etags)) pattern) > >> - (etags--xref-find-definitions (xref-apropos-regexp pattern) t)) > >> + (let ((regexp (xref-apropos-regexp pattern))) > >> + (nconc > >> + (etags--xref-find-definitions regexp t) > >> + (etags--xref-apropos-additional regexp)))) > > > > I'm not sure I understand why is this specific to the etags backend. > > The spec seems to be more general, and xref-find-apropos is not > > specific to etags, right? > > If as you say above it is for feature parity with 'M-x tags-apropos', > then the previously sent patch should be enough. If you think it's enough, please go ahead and install it. Thanks.