From: Eli Zaretskii <eliz@gnu.org>
To: "João Paulo Labegalini de Carvalho" <jaopaulolc@gmail.com>
Cc: casouri@gmail.com, emacs-devel@gnu.org
Subject: Re: Initial fontification in sh-mode with tree-sittter
Date: Sun, 13 Nov 2022 08:23:05 +0200 [thread overview]
Message-ID: <83edu7mkza.fsf@gnu.org> (raw)
In-Reply-To: <CAGjvy2_wrrPD_hbEVaZUKJ2+uZcW2TshWchL2zZWC741AhWgKg@mail.gmail.com> (message from João Paulo Labegalini de Carvalho on Sat, 12 Nov 2022 15:04:26 -0700)
> From: João Paulo Labegalini de Carvalho <jaopaulolc@gmail.com>
> Date: Sat, 12 Nov 2022 15:04:26 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>
> I see. This is tree-sitter-bash’s problem. When there are only newlines between two EOF’s, the parser
> erroneously marks everything that follows as heredoc_body. I tried tree-sitter’s online demo and it gives
> the same result[1]. We should report this to tree-sitter-bash’s author.
>
> Sorry for the delay. I confirmed the problem was in the tree-sitter-bash side and submitted a PR to fix it:
> https://github.com/tree-sitter/tree-sitter-bash/pull/137
> Once my fixes are pulled in, there is no change required to my patch.
Do we need to wait for their fix, or can we have code that will start
working correctly when they fix the parser?
next prev parent reply other threads:[~2022-11-13 6:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 22:01 Initial fontification in sh-mode with tree-sittter João Paulo Labegalini de Carvalho
2022-10-27 23:09 ` João Paulo Labegalini de Carvalho
2022-10-27 23:40 ` João Paulo Labegalini de Carvalho
2022-10-28 8:12 ` Yuan Fu
2022-10-28 15:09 ` Daniel Martín
2022-10-31 2:13 ` Yuan Fu
2022-10-31 21:56 ` Yuan Fu
2022-11-01 0:09 ` Daniel Martín
2022-11-01 0:25 ` Yuan Fu
2022-11-01 7:13 ` Eli Zaretskii
2022-11-01 8:35 ` Yuan Fu
2022-11-01 9:23 ` Eli Zaretskii
[not found] ` <CAGjvy2_6BReOVjSqgTM57+h+Ycjdu1o1TKoQHf6q-ypnAX3=rA@mail.gmail.com>
2022-11-02 19:17 ` Eli Zaretskii
2022-11-03 1:25 ` Yuan Fu
2022-11-03 6:36 ` Eli Zaretskii
2022-11-03 7:16 ` Yuan Fu
2022-11-03 16:08 ` João Paulo Labegalini de Carvalho
2022-11-03 19:12 ` Yuan Fu
2022-11-04 20:44 ` João Paulo Labegalini de Carvalho
2022-11-04 22:50 ` Yuan Fu
2022-11-12 22:04 ` João Paulo Labegalini de Carvalho
2022-11-12 22:28 ` Yuan Fu
2022-11-12 23:57 ` João Paulo Labegalini de Carvalho
2022-11-16 8:34 ` Yuan Fu
2022-11-16 15:57 ` João Paulo Labegalini de Carvalho
2022-11-17 18:25 ` Yuan Fu
2022-11-17 18:53 ` João Paulo Labegalini de Carvalho
2022-11-17 19:11 ` Yuan Fu
2022-11-13 6:23 ` Eli Zaretskii [this message]
2022-11-13 7:01 ` Yuan Fu
2022-11-13 7:26 ` Eli Zaretskii
2022-11-29 21:52 ` João Paulo Labegalini de Carvalho
2022-11-02 20:37 ` [SPAM UNSURE] " Stephen Leake
2022-10-28 0:18 ` Stefan Kangas
2022-10-28 0:48 ` João Paulo Labegalini de Carvalho
2022-10-28 15:27 ` João Paulo Labegalini de Carvalho
2022-10-28 15:57 ` Stefan Kangas
2022-10-28 16:15 ` Stefan Monnier
2022-10-28 16:23 ` Theodor Thornhill
2022-10-28 16:34 ` João Paulo Labegalini de Carvalho
2022-10-28 17:37 ` Stefan Monnier
2022-10-28 17:45 ` Yuan Fu
2022-10-28 18:12 ` Stefan Monnier
2022-11-01 0:33 ` Yuan Fu
2022-11-01 3:38 ` Stefan Monnier
2022-11-01 8:37 ` Yuan Fu
2022-10-29 7:13 ` Augusto Stoffel
2022-10-28 17:44 ` Yuan Fu
2022-11-02 18:22 ` João Paulo Labegalini de Carvalho
2022-11-02 18:55 ` João Paulo Labegalini de Carvalho
2022-11-12 12:47 ` Eli Zaretskii
2022-11-12 19:45 ` Yuan Fu
2022-11-12 19:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edu7mkza.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jaopaulolc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).