unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Uday Reddy <usr.vm.rocks@gmail.com>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: Emacs24 coding system problems
Date: Sun, 25 Nov 2012 18:06:12 +0200	[thread overview]
Message-ID: <83d2z1zmyz.fsf@gnu.org> (raw)
In-Reply-To: <20657.63114.521000.806863@gargle.gargle.HOWL>

> Date: Sun, 25 Nov 2012 10:44:26 +0000
> From: Uday Reddy <usr.vm.rocks@gmail.com>
> Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
> 
> False alarm.  I managed to get the trunk to build on Win32.

I'm confused: is this problem specific to MS-Windows?  I don't think
you ever mentioned Windows in this thread before; did I miss
something?

> I can't get the revision 103292 to compile.  It gave an error
> 
> xdisp.c: In function 'decode_mode_spec':
> xdisp.c:19589:14: error: 'buffer_file_type' undeclared (first use in this functi
> on)
> xdisp.c:19589:14: note: each undeclared identifier is reported only once for eac
> h function it appears in
> mingw32-make[2]: *** [oo-spd/i386/xdisp.o] Error 1
> 
> I am trying the neighbouring revisions.

Uday, this isn't the most efficient way of finding the bug.  It will
waste a lot of your time and energy on overcoming unrelated problems,
especially since 103292 is such a mega-changeset.

The most efficient way is to debug the _current_ codebase.  Not to go
back to prior versions, but go forward.  We are not interested in
finding bugs in past versions, we are interested in finding current
(and future ;-) bugs.

So let's revisit your last finding.  You said:

> Tracing through find-file-noselect-1, I found that `rawfile' was set to
> nil.  Then there is call to `insert-file-contents'.  When it returns,
> enable-multibyte-characters has been set to nil.

The logical next step is to find out what happened during the call to
insert-file-contents.  The most probable suspect is the call to the
function after-insert-file-set-coding.  insert-file-contents calls it
after reading the file into a buffer, in order to find the appropriate
coding-system to set the buffer's buffer-file-coding-system.  Can you
see what happens inside after-insert-file-set-coding?



  reply	other threads:[~2012-11-25 16:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  8:24 Emacs24 coding system problems Uday Reddy
2012-11-02  8:39 ` Andreas Schwab
2012-11-02  8:51   ` Eli Zaretskii
2012-11-02  8:56     ` Eli Zaretskii
2012-11-18 19:06     ` Uday Reddy
2012-11-18 21:07       ` Eli Zaretskii
2012-11-19  4:05         ` Stephen J. Turnbull
2012-11-19  8:43         ` Uday Reddy
2012-11-24 20:29           ` Stefan Monnier
2012-11-25  7:58             ` Uday Reddy
2012-11-25 10:44               ` Uday Reddy
2012-11-25 16:06                 ` Eli Zaretskii [this message]
2012-11-25 20:36                   ` Uday Reddy
2012-11-25 21:10                     ` Eli Zaretskii
2012-11-25 11:48               ` Kazuhiro Ito
2012-11-25 19:58                 ` Uday Reddy
2012-11-25 21:14                   ` Eli Zaretskii
2012-11-25 23:37                     ` Uday Reddy
2012-11-26  3:41                       ` Eli Zaretskii
2012-11-26  8:30                         ` Kazuhiro Ito
2012-11-26 17:16                           ` Eli Zaretskii
2012-11-28 12:39                             ` Kazuhiro Ito
2012-11-28 17:40                               ` Eli Zaretskii
2012-11-28 21:16                             ` Uday S Reddy
2012-11-29  3:46                               ` Eli Zaretskii
2012-11-30 10:58                                 ` Uday Reddy
2012-11-30 13:40                                   ` Eli Zaretskii
2012-12-02  0:46                                     ` Emacs24 unpredictable behaviour [Was: coding system problems] Uday Reddy
2012-12-02  8:06                                       ` Andreas Schwab
2012-12-02 11:42                                       ` Uday Reddy
2012-11-09 17:01 ` Emacs24 coding system problems Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d2z1zmyz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=usr.vm.rocks@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).