From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: FACE_FROM_ID vs FACE_OPT_FROM_ID
Date: Thu, 23 Jun 2016 23:03:52 +0300 [thread overview]
Message-ID: <83d1n73c5z.fsf@gnu.org> (raw)
Paul, can you explain why we need two macros where we had only one?
Two macros with similar effect and unclear rules for when to use each
one doesn't sound like a good idea to me. I've read the commit log
message, which attempts to explain the preference, but I don't think I
understand the criterion -- any face ID can cause FACE_FROM_ID to
produce NULL, if called in some inopportune moment. I also looked at
the places where you used each macro, and I cannot understand why you
decided to use this or that, maybe I'm missing something.
What was the GCC 6.1 complaint that led you to this change?
Same questions for IMAGE_FROM_ID.
next reply other threads:[~2016-06-23 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 20:03 Eli Zaretskii [this message]
2016-06-24 0:23 ` FACE_FROM_ID vs FACE_OPT_FROM_ID Paul Eggert
2016-06-24 8:49 ` Eli Zaretskii
2016-06-24 9:27 ` Paul Eggert
2016-06-24 9:57 ` Eli Zaretskii
2016-06-24 10:00 ` Eli Zaretskii
2016-06-24 11:17 ` Paul Eggert
2016-06-24 13:43 ` Eli Zaretskii
2016-06-24 21:34 ` Paul Eggert
2016-06-25 7:48 ` Eli Zaretskii
2016-06-25 21:34 ` Paul Eggert
2016-07-02 9:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1n73c5z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).