From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: FACE_FROM_ID vs FACE_OPT_FROM_ID Date: Thu, 23 Jun 2016 23:03:52 +0300 Message-ID: <83d1n73c5z.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466712297 12544 80.91.229.3 (23 Jun 2016 20:04:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jun 2016 20:04:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 23 22:04:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGAru-0006Y7-Ll for ged-emacs-devel@m.gmane.org; Thu, 23 Jun 2016 22:04:54 +0200 Original-Received: from localhost ([::1]:39064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGArt-0003TH-Rm for ged-emacs-devel@m.gmane.org; Thu, 23 Jun 2016 16:04:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGArk-0003RT-W1 for emacs-devel@gnu.org; Thu, 23 Jun 2016 16:04:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGArg-0007dA-Q9 for emacs-devel@gnu.org; Thu, 23 Jun 2016 16:04:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGArg-0007d0-NH; Thu, 23 Jun 2016 16:04:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3397 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGArf-0001ap-J3; Thu, 23 Jun 2016 16:04:40 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204706 Archived-At: Paul, can you explain why we need two macros where we had only one? Two macros with similar effect and unclear rules for when to use each one doesn't sound like a good idea to me. I've read the commit log message, which attempts to explain the preference, but I don't think I understand the criterion -- any face ID can cause FACE_FROM_ID to produce NULL, if called in some inopportune moment. I also looked at the places where you used each macro, and I cannot understand why you decided to use this or that, maybe I'm missing something. What was the GCC 6.1 complaint that led you to this change? Same questions for IMAGE_FROM_ID.